Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui-speedspacechart: highlight the 4 steps before and after the cursor #881

Merged
merged 1 commit into from
Feb 10, 2025
Merged

ui-speedspacechart: highlight the 4 steps before and after the cursor #881

merged 1 commit into from
Feb 10, 2025

Conversation

RomainValls
Copy link
Contributor

@RomainValls RomainValls self-assigned this Feb 5, 2025
@RomainValls RomainValls requested a review from a team as a code owner February 5, 2025 12:59
Akctarus
Akctarus reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, works well in most cases, but this one seems odd (only one OP is highlighted, while another may also be on left + 6 OP are highlighted on the cursor right ) :
Capture d’écran 2025-02-07 à 16 22 18
do you have the same behavior when you test it ?

@RomainValls
Copy link
Contributor Author

tested, works well in most cases, but this one seems odd (only one OP is highlighted, while another may also be on left + 6 OP are highlighted on the cursor right ) : Capture d’écran 2025-02-07 à 16 22 18 do you have the same behavior when you test it ?

Thank you, I forgot to use leftOffset. When we dragged the chart on the left or right, it wasn't taken into account 👍

@RomainValls RomainValls force-pushed the rvs/display-steps-close-to-cursor branch from 1c4cc9b to d9f977d Compare February 10, 2025 13:37
Math-R
Math-R approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@RomainValls RomainValls force-pushed the rvs/display-steps-close-to-cursor branch from d9f977d to 2b42746 Compare February 10, 2025 13:48
@RomainValls RomainValls force-pushed the rvs/display-steps-close-to-cursor branch from 2b42746 to 3b36de4 Compare February 10, 2025 13:48
Akctarus
Akctarus approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, lgtm !

@RomainValls RomainValls added this pull request to the merge queue Feb 10, 2025
Merged via the queue into dev with commit c08b9a7 Feb 10, 2025
6 checks passed
@RomainValls RomainValls deleted the rvs/display-steps-close-to-cursor branch February 10, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Math-R Math-R Math-R approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees

@RomainValls RomainValls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: PRs around crosshairs are not highlighted in the GEV
3 participants
@RomainValls @Math-R @Akctarus