-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui-spacetimechart: fix time labels, graduations and captions #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9bbf03
to
91b1d6c
Compare
91b1d6c
to
b06e457
Compare
b06e457
to
77a0060
Compare
emersion
reviewed
Feb 7, 2025
emersion
reviewed
Feb 7, 2025
emersion
reviewed
Feb 7, 2025
emersion
reviewed
Feb 7, 2025
23ce2c3
to
e1f5943
Compare
emersion
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Typo: "up-spacetimechart: fix time graduation" (should be "ui-", not "up-") |
d47cba0
to
5af275d
Compare
Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Valentin Chanas <[email protected]>
5af275d
to
b5e5aa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes OpenRailAssociation/osrd#10688
closes OpenRailAssociation/osrd#10689