Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-spacetimechart: fix time labels, graduations and captions #883

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

anisometropie
Copy link
Contributor

@anisometropie anisometropie commented Feb 5, 2025

@anisometropie anisometropie force-pushed the vcs/fix-time-graduations branch from c9bbf03 to 91b1d6c Compare February 5, 2025 14:26
@anisometropie anisometropie marked this pull request as ready for review February 5, 2025 14:34
@anisometropie anisometropie requested a review from a team as a code owner February 5, 2025 14:34
@anisometropie anisometropie force-pushed the vcs/fix-time-graduations branch from 91b1d6c to b06e457 Compare February 5, 2025 14:37
@anisometropie anisometropie changed the title fix time graduations space time chart time graduations/labels Feb 5, 2025
@anisometropie anisometropie force-pushed the vcs/fix-time-graduations branch from b06e457 to 77a0060 Compare February 6, 2025 10:10
@emersion emersion changed the title space time chart time graduations/labels ui-spacetimechart: fix time labels, graduations and captions Feb 6, 2025
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emersion
Copy link
Member

Typo: "up-spacetimechart: fix time graduation" (should be "ui-", not "up-")

@anisometropie anisometropie force-pushed the vcs/fix-time-graduations branch from d47cba0 to 5af275d Compare February 12, 2025 09:19
@anisometropie anisometropie force-pushed the vcs/fix-time-graduations branch from 5af275d to b5e5aa8 Compare February 12, 2025 09:21
@anisometropie anisometropie added this pull request to the merge queue Feb 12, 2025
Merged via the queue into dev with commit abe8046 Feb 12, 2025
6 checks passed
@anisometropie anisometropie deleted the vcs/fix-time-graduations branch February 12, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space time chart time caption is off time graduation off by 1 or 2 hour
2 participants