Enable import/no-extraneous-dependencies lint #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
changed the title
ui-warped-map needs react-dom, ui-manchette-with-spacetimechart and ui-trackoccupancydiagram need lodash. Signed-off-by: Simon Ser <[email protected]>
Ensure all packages have dependencies properly defined. This is especially important for a monorepo because dependencies might get pulled in by another package by chance. Disable the check for stories, because these depend on the package they're in. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/import-no-extra-deps
branch
from
fb5b38a to
49fb48d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Ensure all packages have dependencies properly defined. This is
especially important for a monorepo because dependencies might get
pulled in by another package by chance.
Disable the check for stories, because these depend on the package
they're in.