Centralize dev dependencies #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osrd-ui's root package provides some re-usable build tool configurations, for instance postcss-base.config.cjs and rollup-base.config.js. Make it so the root package contains the devDependencies required to run these configuration files instead of duplicating them in each sub-package. That way, we don't need to keep all of these in sync when adding/removing a plugin. While at it, drop unused dependencies such as rollup-plugin-serve. Signed-off-by: Simon Ser <[email protected]>
emersion
changed the title
This should be a dev dependency, and it's already in the root package.json. Signed-off-by: Simon Ser <[email protected]>
These are not required at run-time, so we don't need to make osrd-ui users download and install them with osrd-ui. Signed-off-by: Simon Ser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
osrd-ui's root package provides some re-usable build tool configurations, for instance postcss-base.config.cjs and rollup-base.config.js.
Make it so the root package contains the devDependencies required to run these configuration files instead of duplicating them in each sub-package. That way, we don't need to keep all of these in sync when adding/removing a plugin.
While at it, drop unused dependencies such as rollup-plugin-serve.