build: use rollup --failAfterWarnings, diet version #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've got to a point where we've eliminated almost all build errors.
We previously did not notice these because they only show up as
warnings in CI, without making CI fail.
Use rollup --failAfterWarnings so that CI fails when a build error
is emitted.
Leave ui-spacetimechart and ui-trackoccupancydiagram alone, because
these still have a failure due to a circular dependency:
(!) [plugin typescript] ../ui-spacetimechart/src/lib/types.ts (6:8): @rollup/plugin-typescript TS2307: Cannot find module '@osrd-project/ui-trackoccupancydiagram/dist/components/types' or its corresponding type declarations.
/home/runner/work/osrd-ui/osrd-ui/ui-spacetimechart/src/lib/types.ts:6:8
6 } from '@osrd-project/ui-trackoccupancydiagram/dist/components/types';
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Simon Ser <[email protected]>
emersion
changed the title
emersion
requested review from
kmer2016,
RomainValls and
theocrsb
and removed request for
RomainValls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've got to a point where we've eliminated almost all build errors. We previously did not notice these because they only show up as warnings in CI, without making CI fail.
Use rollup --failAfterWarnings so that CI fails when a build error is emitted.
Leave ui-spacetimechart and ui-trackoccupancydiagram alone, because these still have a failure due to a circular dependency:
These remaining errors will be fixed when all charts are refactored into a single package.
Full version here: #833