Upgrade storybook to v8.5.8 #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file is TypeScript already, no need for type comments. Plus the type comment is outdated and pulls the wrong package. Signed-off-by: Simon Ser <[email protected]>
Currently the glob pattern matches too many files: it walks
all of node_modules/ and tries to find stories in there. This is
made more obvious with storybook v8.5.6, which warns about duplicate
stories, for instance:
../node_modules/@osrd-project/ui-warped-map/src/stories/SampleMap.stories.ts,../ui-warped-map/src/stories/SampleMap.stories.ts: Duplicate stories with id: warpedmap-sample-maps--path-longer
Make the glob pattern more restrictive to avoid this.
Signed-off-by: Simon Ser <[email protected]>
Signed-off-by: Simon Ser <[email protected]>
emersion
changed the title
SharglutDev
approved these changes
Feb 20, 2025
|
Here it's a bugfix version upgrade, so we don't need to (the code in this PR works fine with both the old and new versions of storybook). Side note, dependabot also doesn't update During a minor version upgrade, it's indeed best to bump the version in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.