Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-spacetimechart: handle devicePixelRatio changes #918

Merged
merged 1 commit into from
Feb 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions ui-spacetimechart/src/hooks/useCanvas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useCallback, useContext, useEffect, useMemo, useRef, useState } from 'r

import { isEqual } from 'lodash';

import { useDevicePixelRatio } from './useDevicePixelRatio';
import { useSize } from './useSize';
import { CanvasContext } from '../lib/context';
import {
Expand Down Expand Up @@ -58,6 +59,8 @@ export function useCanvas(
sizeRef.current = size;
}, [size]);

const devicePixelRatio = useDevicePixelRatio();

/**
* This function renders all picking layers:
*/
Expand Down Expand Up @@ -223,27 +226,25 @@ export function useCanvas(

// Handle resizing:
useEffect(() => {
const scale = window.devicePixelRatio || 1;

for (const id in canvasesRef.current) {
const canvas = canvasesRef.current[id];
const ctx = contextsRef.current[id];

if (canvas) {
canvas.style.width = size.width + 'px';
canvas.style.height = size.height + 'px';
canvas.setAttribute('width', size.width * scale + 'px');
canvas.setAttribute('height', size.height * scale + 'px');
canvas.setAttribute('width', size.width * devicePixelRatio + 'px');
canvas.setAttribute('height', size.height * devicePixelRatio + 'px');

// Reset the transform to identity, then apply the new scale
ctx.setTransform(1, 0, 0, 1, 0, 0);
ctx.scale(scale, scale);
ctx.scale(devicePixelRatio, devicePixelRatio);
}
}

draw();
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [size]);
}, [size, devicePixelRatio]);

// Read picking layer on position change:
useEffect(() => {
Expand Down
23 changes: 23 additions & 0 deletions ui-spacetimechart/src/hooks/useDevicePixelRatio.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { useEffect, useState } from 'react';

export function useDevicePixelRatio() {
const [ratio, setRatio] = useState(window.devicePixelRatio || 1);

useEffect(() => {
if (!window.matchMedia || !window.devicePixelRatio) {
return undefined;
}

const handleChange = () => {
setRatio(window.devicePixelRatio);
};

const mediaQuery = window.matchMedia(`(resolution: ${window.devicePixelRatio}dppx)`);
mediaQuery.addEventListener('change', handleChange);
return () => {
mediaQuery.removeEventListener('change', handleChange);
};
}, [ratio]);

return ratio;
}