front: remove input-wrapper class from input component #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
reviewed
Feb 24, 2025
SharglutDev
force-pushed
the
ui-core/input/remove-input-wrapper-class
branch
from
409e815 to
e5a2e14
Compare
This div/class was used to easily display the focus style around the input when focusing it with tab. The focus style is now displayed via a pseudo element. Signed-off-by: SharglutDev <[email protected]>
SharglutDev
force-pushed
the
ui-core/input/remove-input-wrapper-class
branch
from
e5a2e14 to
db02831
Compare
anisometropie
approved these changes
Feb 25, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This div/class was used to easily display the focus style around the input when focusing it with tab. The focus style is now displayed via a pseudo element.
close #921
Maybe there was other way to change this behavior, it's totally debatable.