Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-spacetimechart: remove vitest dependency #926

Merged
merged 1 commit into from
Feb 24, 2025
Merged

ui-spacetimechart: remove vitest dependency #926

merged 1 commit into from
Feb 24, 2025

Conversation

emersion
Copy link
Member

vitest is not a runtime dependency: it's a devDependency. Drop it since the root package.json already pulls it in.

vitest is not a runtime dependency: it's a devDependency. Drop it
since the root package.json already pulls it in.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested a review from a team as a code owner February 24, 2025 09:40
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@jacomyal
Copy link
Contributor

Same here, all good to me 👍

@emersion emersion added this pull request to the merge queue Feb 24, 2025
Merged via the queue into dev with commit f0bff58 Feb 24, 2025
6 checks passed
@emersion emersion deleted the emr/vitest-dep branch February 24, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants