Remove dist/ JS imports #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are effectively public API, because they are referenced from SpaceTimeChartProps. Signed-off-by: Simon Ser <[email protected]>
Instead, import from the package itself. That way we can ensure we're only importing public API and we're not messing with internal types. Drop the eslint-disable import/no-unresolved comments, because these errors aren't triggered anymore. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/no-dist-imports
branch
from
9cb3b0a to
1f50f2a
Compare
jacomyal
requested changes
Feb 24, 2025
jacomyal
approved these changes
Feb 24, 2025
|
LGTM 👍 |
kmer2016
approved these changes
Feb 24, 2025
emersion
added a commit
that referenced
this pull request
Feb 25, 2025
Follow-up for #928: I missed one. Signed-off-by: Simon Ser <[email protected]>
emersion
added a commit
that referenced
this pull request
Feb 25, 2025
Follow-up for #928: I missed one. Signed-off-by: Simon Ser <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
Follow-up for #928: I missed one. Signed-off-by: Simon Ser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, import from the package itself. That way we can ensure
we're only importing public API and we're not messing with
internal types.
Drop the eslint-disable import/no-unresolved comments, because
these errors aren't triggered anymore.
See individual commits.