ui-manchette-with-spacetimechart: add ManchetteWithSpaceTimeChart #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
emr/simple-manchette-with-stc
branch
from
02e3569 to
e4b1831
Compare
This type can be useful to osrd-ui users. Signed-off-by: Simon Ser <[email protected]>
This is a component designed for simple use-cases. It's easier to
use than the hook. Users can still decide to use the hook instead
of this component, especially when they need more customizability.
Other components can be passed in for the header and SpaceTimeChart,
and additional properties can be passed to Manchette/SpaceTimeChart.
This is a breaking API change: the hook is no longer the default
export for ui-manchette-with-spacetimechart. Users need to replace:
import useManchetteWithSpaceTimeChart from 'ui-manchette-with-spacetimechart';
with:
import { useManchetteWithSpaceTimeChart } from 'ui-manchette-with-spacetimechart';
Signed-off-by: Simon Ser <[email protected]>
Add a story to demonstrate the use of ManchetteWithSpaceTimeChart. It behaves the same as the default story. Signed-off-by: Simon Ser <[email protected]>
emersion
force-pushed
the
emr/simple-manchette-with-stc
branch
from
e4b1831 to
fab0f95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a component designed for simple use-cases. It's easier to
use than the hook. Users can still decide to use the hook instead
of this component, especially when they need more customizability.
Other components can be passed in for the header and SpaceTimeChart,
and additional properties can be passed to Manchette/SpaceTimeChart.
This is a breaking API change: the hook is no longer the default
export for ui-manchette-with-spacetimechart. Users need to replace:
with:
See individual commits.