Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-spacetimechart: fix op graduation display when hidden #940

Merged

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Feb 25, 2025

add operationnalPoints in fingerprint to trigger changes in useCanvas() then redraw charts if one or many operationnalPoints is hidden by machette settings panel

to test it, go to work-schedules spacetimechartstory, remove one or several OPs

close OpenRailAssociation/osrd#9970

add operationnalPoints in fingerprint to trigger changes in useCanvas()
then redraw charts if one or many operationnalPoints is hidden by
machette settings panel

Signed-off-by: Yohh <[email protected]>
@Yohh Yohh requested review from kmer2016 and RomainValls February 25, 2025 14:57
@Yohh Yohh requested a review from a team as a code owner February 25, 2025 14:57
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested 👍

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Yohh Yohh added this pull request to the merge queue Feb 26, 2025
Merged via the queue into dev with commit 652440d Feb 26, 2025
6 checks passed
@Yohh Yohh deleted the yoh/ui-spacetimechart-fix-op-graduation-disply-when-hidden branch February 26, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GET horizontal lines aren't updated when changing manchette visible OPs
3 participants