ui-chart: spacetimechart: bordered path layer #962
+123
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Math-R
force-pushed
the
mrd/spacetimechart/bordered-layer
branch
2 times, most recently
from
4da5206 to
1e55ad0
Compare
Math-R
force-pushed
the
mrd/spacetimechart/bordered-layer
branch
from
1e55ad0 to
720dca2
Compare
Math-R
changed the title
Math-R
changed the title
Math-R
force-pushed
the
mrd/spacetimechart/bordered-layer
branch
from
720dca2 to
fd1bfd7
Compare
Yohh
reviewed
Mar 6, 2025
ui-charts/src/spaceTimeChart/stories/additional-data.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Uriel-Sautron <[email protected]> Signed-off-by: Math_R_ <[email protected]>
Uriel-Sautron
force-pushed
the
mrd/spacetimechart/bordered-layer
branch
from
fd1bfd7 to
b833579
Compare
emersion
reviewed
Mar 7, 2025
| @@ -66,6 +67,13 @@ export type PathLayerProps = { | |||
| color: string; | |||
| pickingTolerance?: number; | |||
| level?: PathLevel; | |||
| border?: { | |||
| offset: number; | |||
| level: PathLevel; | |||
emersion
reviewed
Mar 7, 2025
| const drawAll = useCallback<DrawingFunction>( | ||
| (ctx, stcContext) => { | ||
| if (border !== undefined) { |
There was a problem hiding this comment.
Nit: no need for an if here, since we already have one inside the function.
emersion
reviewed
Mar 7, 2025
| drawSegments(totalPathWidth + borderWidth * 2); | ||
|
|
||
| if (border.backgroundColor) { | ||
| drawSegments(totalPathWidth, border.backgroundColor); |
There was a problem hiding this comment.
This is a bit confusing: when there is no background color, I would've expected a thin width-sized border offset away from the path. However a thick path is painted instead:
emersion
reviewed
Mar 7, 2025
| if (i === 0) { | ||
| ctx.moveTo(x, y); | ||
| } else if (i === segments.length - 1) { | ||
| ctx.lineTo(x - border.offset / 2, y); |
There was a problem hiding this comment.
Why the - border.offset / 2 here? It seems like the spacing on the right is smaller than offset with this adjustment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow the user to add a border around a PathLayer.
it closes #11056