Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design-docs: timetable: unify arrival times and margin types #164

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

multun
Copy link
Contributor

@multun multun commented Dec 22, 2023

No description provided.

@multun multun changed the title simplify the margins data model design-docs: timetable: unify arrival times and margin types Dec 22, 2023
@multun multun mentioned this pull request Dec 22, 2023
@flomonster
Copy link
Contributor

Idea of new model:

  • We could have only one type of margin (like the engineering margin).
  • Each margin can have an associated algorithm (linear or mareco).
  • This list of margins can be reduced to two sets of margins (linear and mareco)
  • This set of margins can be applied using the "AUTO" method avoiding problems of speed continuity.

@flomonster
Copy link
Contributor

flomonster commented Jan 16, 2024

We asked the users questions and this modified our base design. a0ea662

@multun
Copy link
Contributor Author

multun commented Jan 16, 2024

I'd love to further simplify the proposal given the user feedback. I can do this next week, or someone can give it a try until then

@multun multun force-pushed the margins-v3 branch 4 times, most recently from d97a127 to 48ff067 Compare January 25, 2024 16:49
Copy link
Contributor

@Khoyo Khoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should very much specify what units are supported. This can be done later though

@multun multun force-pushed the margins-v3 branch 2 times, most recently from 03d9a34 to ec2349b Compare January 25, 2024 19:42
@flomonster flomonster merged commit a440a66 into timetable-v2 Feb 2, 2024
1 check passed
@flomonster flomonster deleted the margins-v3 branch February 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants