Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update front guidelines for imports #184

Merged
merged 1 commit into from
Mar 13, 2024
Merged

doc: update front guidelines for imports #184

merged 1 commit into from
Mar 13, 2024

Conversation

SharglutDev
Copy link
Contributor

Update guidelines after recent updates on front type imports and imports order

clarani
clarani reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's possible to have 2 commits, and in the first one you format and lint frontend-conventions ? This way, we can more clearly see your changes :)

@SharglutDev SharglutDev force-pushed the pfn-add-front-imports-guidelines branch 2 times, most recently from ab89ea5 to 497bec9 Compare March 13, 2024 13:36
@SharglutDev SharglutDev force-pushed the pfn-add-front-imports-guidelines branch from 497bec9 to cf0ffb4 Compare March 13, 2024 14:11
clarani
clarani approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Akctarus
Akctarus approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@SharglutDev SharglutDev merged commit cadcef2 into master Mar 13, 2024
2 checks passed
@SharglutDev SharglutDev deleted the pfn-add-front-imports-guidelines branch March 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SharglutDev @clarani @Akctarus