front: fix isEqualDate()

toLocaleString() returns an arbitrary human-readable string. For instance, in France it returns "18/02/2025 13:32:08" and in Korea it returns "2025. 2. 18. 오후 1:32:08". The string cannot be used for anything else than display. Trying to extract the date from it will not work: substring(0, 10) will give "2025. 2. 1" in Korea (dropping the "8"). As a result, any day with the same first digit will be interpreted as equal. Fix this by comparing the year, month, and day of the month instead. Signed-off-by: Simon Ser <[email protected]>
OpenRailAssociation · Feb 24, 2025 · 21d2dbb · 21d2dbb
1 parent 6d6298f
commit 21d2dbb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/front/src/utils/date.ts b/front/src/utils/date.ts
@@ -193,10 +193,10 @@ export const formatDateString = (date?: Date | null) => {
   return dayjs(date).format('DD/MM/YY');
 };
 
-export const formatLocaleDate = (date: Date) => date.toLocaleString().substring(0, 10);
-
 export const isEqualDate = (searchDate: Date, startDate: Date) =>
-  formatLocaleDate(searchDate) === formatLocaleDate(startDate);
+  searchDate.getFullYear() === startDate.getFullYear() &&
+  searchDate.getMonth() === startDate.getMonth() &&
+  searchDate.getDate() === startDate.getDate();
 
 /**
  * @param start timestamp or Date object