front: fix stdcm empty ch list in new query

Signed-off-by: SharglutDev <[email protected]>
OpenRailAssociation · Jan 20, 2025 · 601f66f · 601f66f
1 parent 8affe7b
commit 601f66f
Showing 1 changed file with 25 additions and 12 deletions.
diff --git a/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx b/front/src/applications/stdcm/components/StdcmForm/StdcmOperationalPoint.tsx
@@ -3,6 +3,7 @@ import { useEffect, useMemo, useState } from 'react';
 import { Select, ComboBox } from '@osrd-project/ui-core';
 import { useTranslation } from 'react-i18next';
 
+import type { SearchResultItemOperationalPoint } from 'common/api/osrdEditoastApi';
 import useSearchOperationalPoint from 'common/Map/Search/useSearchOperationalPoint';
 import { useOsrdConfActions } from 'common/osrdContext';
 import type { StdcmConfSliceActions } from 'reducers/osrdconf/stdcmConf';
@@ -23,6 +24,20 @@ function formatChCode(chCode: string) {
   return chCode === '' ? 'BV' : chCode;
 }
 
+const extractChCodes = (searchResults: SearchResultItemOperationalPoint[], selectedCI: CIOption) =>
+  searchResults
+    .filter((pr) => pr.name === selectedCI.name)
+    .reduce((acc, pr) => {
+      const newObject = {
+        label: formatChCode(pr.ch),
+        id: pr.ch,
+        coordinates: pr.geographic.coordinates as [number, number],
+      };
+      const isDuplicate = acc.some((option) => option.label === newObject.label);
+      if (!isDuplicate) acc.push(newObject);
+      return acc;
+    }, [] as CHOption[]);
+
 const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperationalPointProps) => {
   const { t } = useTranslation('stdcm');
   const dispatch = useAppDispatch();
@@ -93,18 +108,7 @@ const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperatio
 
   const handleCiSelect = (selectedSuggestion?: CIOption) => {
     if (selectedSuggestion) {
-      const newChSuggestions = searchResults
-        .filter((pr) => pr.name === selectedSuggestion.name)
-        .reduce((acc, pr) => {
-          const newObject = {
-            label: formatChCode(pr.ch),
-            id: pr.ch,
-            coordinates: pr.geographic.coordinates as [number, number],
-          };
-          const isDuplicate = acc.some((option) => option.label === newObject.label);
-          if (!isDuplicate) acc.push(newObject);
-          return acc;
-        }, [] as CHOption[]);
+      const newChSuggestions = extractChCodes(searchResults, selectedSuggestion);
       setChSuggestions(newChSuggestions);
     } else {
       setChSuggestions([]);
@@ -147,6 +151,15 @@ const StdcmOperationalPoint = ({ location, pathStepId, disabled }: StdcmOperatio
     }
   }, [location]);
 
+  useEffect(() => {
+    // If we start a new query with inputs (ch suggestions will be empty at load),
+    // fetch the ch list again for the corresponding CI
+    if (chSuggestions.length === 0 && selectedCi && searchResults.length > 0) {
+      const updatedChSuggestions = extractChCodes(searchResults, selectedCi);
+      setChSuggestions(updatedChSuggestions);
+    }
+  }, [searchResults, selectedCi, chSuggestions]);
+
   return (
     <div className="location-line">
       <div className="col-9 ci-input">