front: fix review comment

Signed-off-by: nncluzu <[email protected]>
OpenRailAssociation · Nov 21, 2024 · 63bad33 · 63bad33
1 parent fa93850
commit 63bad33
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 12 deletions.
diff --git a/front/public/locales/en/translation.json b/front/public/locales/en/translation.json
@@ -52,9 +52,10 @@
       }
     },
     "units": {
-      "day": "j",
+      "day": "d",
       "hour": "h",
-      "minute": "min"
+      "minute": "min",
+      "km": "km"
     }
   },
   "Editor": {

diff --git a/front/public/locales/fr/translation.json b/front/public/locales/fr/translation.json
@@ -52,9 +52,10 @@
       }
     },
     "units": {
-      "day": "d",
+      "day": "j",
       "hour": "h",
-      "minute": "min"
+      "minute": "min",
+      "km": "km"
     }
   },
   "Editor": {

diff --git a/front/src/applications/stdcm/components/StdcmResults/StdcmSimulationNavigator.tsx b/front/src/applications/stdcm/components/StdcmResults/StdcmSimulationNavigator.tsx
@@ -58,15 +58,15 @@ const StdcmSimulationNavigator = ({
             let formatedTotalLength = '';
             let formatedTripDuration = '';
 
-            if (hasResults(outputs) && outputs.results.simulation.final_output.times.length > 0) {
+            if (hasResults(outputs)) {
               const { results } = outputs;
               const lastPointTime = results.simulation.final_output.times.at(-1)!;
-              const departureTimeInTs = new Date(results.departure_time).getTime();
+              const departureTimeInMs = new Date(results.departure_time).getTime();
 
-              formatedTotalLength = `${Math.round(mmToKm(results.path.length))} km `;
+              formatedTotalLength = `${Math.round(mmToKm(results.path.length))} ${t('common.units.km', { ns: 'translation' })} `;
               formatedTripDuration = formatTimeDifference(
-                departureTimeInTs,
-                lastPointTime + departureTimeInTs
+                departureTimeInMs,
+                lastPointTime + departureTimeInMs
               );
             }
 

diff --git a/front/src/styles/scss/_variables.scss b/front/src/styles/scss/_variables.scss
@@ -67,6 +67,7 @@ $colors: (
   'primary90': #180f47,
   'selection20': #fff2b3,
   'success30': #3cca80,
+  'success60': #0b723c,
   'warning5': #fdf5e1,
   'warning30': #eaa72b,
   'warning60': #7d521e,

diff --git a/front/src/styles/scss/applications/stdcm/_results.scss b/front/src/styles/scss/applications/stdcm/_results.scss
@@ -51,8 +51,9 @@
         overflow-x: hidden;
 
         .simulation-item {
+          width: 160px;
           display: inline-block;
-          margin: 9px 39px 0 0;
+          margin-right: 32px;
           cursor: pointer;
 
           .simulation-metadata {
@@ -93,7 +94,7 @@
 
           &.selected {
             .simulation-metadata {
-              color: rgb(121, 118, 113);
+              color: var(--grey50);
             }
 
             .simulation-name {
@@ -110,7 +111,7 @@
           &.retained {
             .simulation-name,
             .simulation-metadata {
-              color: rgb(11, 114, 60);
+              color: var(--success60);
             }
           }