Skip to content

Commit

Permalink
Nwz/bugfixes and minor cosmetic corrections (#2638)
Browse files Browse the repository at this point in the history
* front: transform map carto in hook & add new icon

* front: hook & change icon for osrd/timetable

* front: hook & change icon of editor home

* front: hook & change icon for stdcm

* front: change icon for opendataimport

* front: change icon on customget

* front: spelling corrections to please Céline

* front: correct customGet data conversion on stops

* front: CrudInfra: working rename endpoint

* front: spelling corrections

* front: CrudInfra: rework of edition/selection switch

* front: RollingStocks selector: better & smaller UI

* front: RollingStocks: isolate & moving to common

* front: correct checkbox & radio selectors

* front: map: a bit of cleaning
  • Loading branch information
nicolaswurtz authored and alexandredamiron committed Jan 17, 2023
1 parent 9937378 commit a25c3bb
Show file tree
Hide file tree
Showing 43 changed files with 316 additions and 377 deletions.
4 changes: 2 additions & 2 deletions front/public/locales/fr/allowances.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
"engineeringAllowances": "Marges de construction",
"margedTrainSchedule": "Avec marges",
"allowanceByInterval": "Marges par intervalles",
"ecoAllowanceByInterval": "Marches Economiques par intervalles",
"ecoAllowanceByInterval": "Marches économiques par intervalles",
"allowanceModified": {
"standardAllowanceAdd": "Marge de régularité ajoutée / modifiée",
"standardAllowanceDel": "Marge de régularité supprimée",
"anyAllowanceModified": "Marge modifiée",
"anyAllowanceModificationError": "Erreur à la modification de marge"
},
"specificValuesOnIntervals" : "Valeurs spécifiques sur intervales",
"specificValuesOnIntervals" : "Valeurs spécifiques sur intervalles",
"allowanceGlobalType": {
"standard": "Standard",
"engineering": "Construction"
Expand Down
2 changes: 1 addition & 1 deletion front/public/locales/fr/drivertrainschedule.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"numberoflines": "Nombre de lignes",
"origin": "Origine",
"pk": "PK",
"place": "Etablissement",
"place": "Établissement",
"placeholderline": "",
"rollingstock": "Matériel roulant",
"speed": "Vitesse",
Expand Down
4 changes: 2 additions & 2 deletions front/public/locales/fr/infraManagement.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
"unableToRetrieveInfraList": "Récupération liste d'infra impossible",
"noEmptyName": "Veuillez renseigner un nom"
},
"goToEditionMode": "Édition",
"goToStandardMode": "Sélection",
"goToEditionMode": "Éditer",
"goToStandardMode": "Retour à la sélection",
"infraChoice": "Infrastructures",
"infraManagement": "Gestion des infrastructures",
"infraName": "Nom de l'infrastructure",
Expand Down
2 changes: 1 addition & 1 deletion front/public/locales/fr/opendata.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"openOSRDConfig": "Infra / Table horaire / Matériel",
"startTime": "DÉBUT",
"status": {
"calculatingTrainSchedule": "Calcul de marches en cours...",
"calculatingTrainSchedule": "Calcul de marches en cours",
"calculatingTrainScheduleComplete": "Calcul de marches terminé",
"calculatingTrainScheduleCompleteAll": "Tous les calculs de marches sont terminés.",
"calculatingTrainScheduleError": "Le calcul de marche a échoué",
Expand Down
6 changes: 3 additions & 3 deletions front/public/locales/fr/osrdconf.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@
"launchSimulation": "Démarrer",
"manageVias": "Gestion des étapes",
"noTimetable": "Choisissez une grille horaire",
"noTrainCompo": "Aucun matériel défini...",
"noTrainCompo": "Aucun matériel défini",
"noplacechosen": "Aucun point défini",
"origin": "Origine",
"pleaseWait": "Veuillez patientez",
"rollingstock": "Matériel",
"searchingItinerary": "Nous recherchons un itinéraire pour vote demande....",
"searchingItinerary": "Recherche de sillon…",
"simulation": "Simulation",
"spaceSpeedGraphic": "Graphique Espace-Vitesse",
"speedLimitByTag": "Code de composition",
"stdcmComputation": "Calcul de l'itinéraire",
"stdcmNoResults": "Désolé, aucun sillon n'a pu être trouvé avec les paramètre renseignés",
"stdcmNoResults": "Aucun sillon trouvé",
"stdcmResults": "Résultats",
"stopSimulation": "Stopper",
"timetable": "Grille horaire",
Expand Down
8 changes: 2 additions & 6 deletions front/public/locales/fr/rollingstock.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,8 @@
"all": "Toutes les courbes",
"default": "Courbe par défaut"
},
"dualMode": "Bimode",
"dureeminfermportes": "Durée de fermeture des portes",
"dureeminouvportes": "Durée d'ouverture des portes",
"electric": "Électrique",
"electricOnly": "Uniquement Eléctrique",
"emCount": "Nombre d'éléments",
"electricOnly": "Uniquement éléctrique",
"equipement": "Équipement",
"family": "Famille",
"intertiaCoefficient": "Coefficient d'inertie",
Expand Down Expand Up @@ -50,7 +46,7 @@
"timetableGamma": "Décélération horaire",
"title": "Générateur de composition matériel train",
"tractionMode": "Mode de traction",
"waitingLoader": "Veuillez patienter, chargement de la base de données matériel...",
"waitingLoader": "Veuillez patienter, chargement de la base de données matériel",
"weight": "Masse",
"yes": "Oui"
}
8 changes: 4 additions & 4 deletions front/public/locales/fr/simulation.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
"errorMessages": {
"unableToRetrieveTrainSchedule": "Calcul de marche impossible"
},
"isWorking": "Calcul de la simulation en cours...",
"labels": "Etiquettes",
"isWorking": "Calcul de la simulation en cours",
"labels": "Étiquettes",
"loadingTrain": "Chargement du train",
"ManualOffset": "Ajout de secondes au train",
"ModalEdit": "Edition d'un train",
"ModalEdit": "Édition d'un train",
"name": "Nom",
"noData": "Aucune donnée disponible",
"null": "Lieu non renseigné",
Expand Down Expand Up @@ -43,5 +43,5 @@
},
"trainList": "Liste des trains",
"speedLimitComposition": "Composition",
"waiting": "Chargement en cours..."
"waiting": "Chargement en cours"
}
4 changes: 2 additions & 2 deletions front/public/locales/fr/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"itinerary": "Itinéraire",
"help": "Aide",
"help-display": "Afficher l'aide",
"loading": "Chargement...",
"loading": "Chargement",
"save": "Sauvegarder",
"search": "Rechercher",
"settings": "Paramètres",
Expand Down Expand Up @@ -202,7 +202,7 @@
"passwordErrorMsg": "Le mot de passe est probablement incorrect.",
"pleaseconnect": "Veuillez vous connecter",
"serverError": "Erreur de connexion au serveur",
"trying": "Tentative de reconnexion...",
"trying": "Tentative de reconnexion",
"username": "Nom d'utilisateur",
"usernameErrorMsg": "Le nom d'utilisateur est probalement incorrect."
},
Expand Down
47 changes: 18 additions & 29 deletions front/src/applications/carto/Home.js
Original file line number Diff line number Diff line change
@@ -1,36 +1,25 @@
import React from 'react';
import PropTypes from 'prop-types';
import { withTranslation } from 'react-i18next';
import { useTranslation } from 'react-i18next';
import { Route, Routes } from 'react-router-dom';
import config from 'config/config';
import NavBarSNCF from 'common/BootstrapSNCF/NavBarSNCF';
import logo from 'assets/logo_osrd_seul_blanc.svg';
import logo from 'assets/pictures/home/map.svg';
import Map from './Map';

class HomeCartoLegacy extends React.Component {
static propTypes = {
t: PropTypes.func.isRequired,
};

render() {
const { t } = this.props;
return (
<>
<NavBarSNCF appName={t('Home.map')} logo={logo} />
<div className="no-mastnav">
<Routes>
<Route path="/" element={<Map urlmap={config.proxy} />} />
<Route
path="/:urlLat/:urlLon/:urlZoom/:urlBearing/:urlPitch"
element={<Map urlmap={config.proxy} />}
/>
</Routes>
</div>
</>
);
}
export default function HomeCartoLegacy() {
const { t } = useTranslation('home');
return (
<>
<NavBarSNCF appName={t('map')} logo={logo} />
<div className="no-mastnav">
<Routes>
<Route path="/" element={<Map urlmap={config.proxy} />} />
<Route
path="/:urlLat/:urlLon/:urlZoom/:urlBearing/:urlPitch"
element={<Map urlmap={config.proxy} />}
/>
</Routes>
</div>
</>
);
}

const HomeCarto = withTranslation()(HomeCartoLegacy);

export default HomeCarto;
8 changes: 4 additions & 4 deletions front/src/applications/customget/Home.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ import MastNavSNCF from 'common/BootstrapSNCF/MastNavSNCF';
import NavBarSNCF from 'common/BootstrapSNCF/NavBarSNCF';
import { NotificationsState } from 'common/Notifications';
import React from 'react';
import logo from 'assets/logo_osrd_seul_blanc.svg';
import logo from 'assets/pictures/home/customget.svg';
import { useTranslation } from 'react-i18next';

import CustomGET from 'applications/customget/views/CustomGET';

import './Home.scss';

function HomeCustomGET() {
const { t } = useTranslation('customget');
const { t } = useTranslation(['customget', 'home']);

return (
<div className="customget-home">
Expand All @@ -35,13 +35,13 @@ function HomeCustomGET() {
data-target="#add-file-modal"
>
<i className="icons-add icons-size-1x5" aria-hidden="true" />
<span className="font-weight-medium">{t('uploadFile')}</span>
<span className="font-weight-medium">{t('customget:uploadFile')}</span>
</button>
</li>
</div>
}
/>
<NavBarSNCF appName="OSRD" logo={logo} />
<NavBarSNCF appName={t('home:customget')} logo={logo} />
<Routes>
<Route path="" element={<CustomGET />} />
</Routes>
Expand Down
17 changes: 9 additions & 8 deletions front/src/applications/customget/components/convertData.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,14 @@ const convertStops = (steps) => {
duration: step.time - beforeStepTime,
name: step.label,
position: step.position,
time: step.time,
time: beforeStepTime,
type: step.type,
});
}
beforeStepName = step.label;
beforeStepTime = step.time;
beforeStepName = step.label;
});
console.log(newStepList);
return newStepList;
};

Expand All @@ -49,23 +50,23 @@ const convertData = (trains) => {
speeds: [],
base: {
head_positions: [
train.space_time_curves.time_table
? train.space_time_curves.time_table.map((step) => ({
train.space_time_curves.actual
? train.space_time_curves.actual.map((step) => ({
time: step.time,
position: step.position,
}))
: train.space_time_curves[1].points.map((step) => ({
: train.space_time_curves[0].points.map((step) => ({
time: step.time,
position: step.position,
})),
],
tail_positions: [
train.space_time_curves.actual
? train.space_time_curves.actual.map((step) => ({
train.space_time_curves.time_table
? train.space_time_curves.time_table.map((step) => ({
time: step.time,
position: step.position,
}))
: train.space_time_curves[0].points.map((step) => ({
: train.space_time_curves[1].points.map((step) => ({
time: step.time,
position: step.position,
})),
Expand Down
45 changes: 17 additions & 28 deletions front/src/applications/editor/Home.jsx
Original file line number Diff line number Diff line change
@@ -1,34 +1,23 @@
import React from 'react';
import PropTypes from 'prop-types';
import { withTranslation } from 'react-i18next';
import { useTranslation } from 'react-i18next';
import { Route, Routes } from 'react-router-dom';

import config from '../../config/config';
import logo from '../../assets/logo_osrd_seul_blanc.svg';
import NavBarSNCF from '../../common/BootstrapSNCF/NavBarSNCF';
import config from 'config/config';
import logo from 'assets/pictures/home/editor.svg';
import NavBarSNCF from 'common/BootstrapSNCF/NavBarSNCF';
import Editor from './Editor';

class HomeEditorUnplugged extends React.Component {
static propTypes = {
t: PropTypes.func.isRequired,
};

render() {
const { t } = this.props;
return (
<>
<NavBarSNCF appName={t('Editor.title')} logo={logo} />
<div className="no-mastnav">
<Routes>
<Route path="/" element={<Editor urlmap={config.proxy} />} />
<Route path="/:infra" element={<Editor urlmap={config.proxy} />} />
</Routes>
</div>
</>
);
}
export default function HomeEditorUnplugged() {
const { t } = useTranslation('home');
return (
<>
<NavBarSNCF appName={t('editor')} logo={logo} />
<div className="no-mastnav">
<Routes>
<Route path="/" element={<Editor urlmap={config.proxy} />} />
<Route path="/:infra" element={<Editor urlmap={config.proxy} />} />
</Routes>
</div>
</>
);
}

const HomeEditor = withTranslation()(HomeEditorUnplugged);

export default HomeEditor;
12 changes: 8 additions & 4 deletions front/src/applications/opendata/Home.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,24 @@ import NavBarSNCF from 'common/BootstrapSNCF/NavBarSNCF';
import { NotificationsState } from 'common/Notifications';
import { useTranslation } from 'react-i18next';
import { MdMoreTime } from 'react-icons/md';
import logo from 'assets/logo_osrd_seul_blanc.svg';
import logo from 'assets/pictures/home/opendata.svg';
import './opendata.scss';
import OpenDataImport from './OpenDataImport';

export default function HomeOpenData() {
const { t } = useTranslation(['opendata']);
const { t } = useTranslation(['opendata', 'home']);
return (
<>
<MastNavSNCF
items={
<MastNavItemSNCF link="/opendata/import" linkname={t('import')} icon={<MdMoreTime />} />
<MastNavItemSNCF
link="/opendata/import"
linkname={t('opendata:import')}
icon={<MdMoreTime />}
/>
}
/>
<NavBarSNCF appName="OSRD / Open data" logo={logo} />
<NavBarSNCF appName={t('home:opendataimport')} logo={logo} />
<Routes>
<Route path="/import" element={<OpenDataImport />} />
<Route path="" element={<Navigate to="/opendata/import" replace />} />
Expand Down
2 changes: 1 addition & 1 deletion front/src/applications/opendata/components/TrainDetail.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import React, { useState } from 'react';
import PropTypes from 'prop-types';
import nextId from 'react-id-generator';
import { seconds2hhmmss } from 'applications/opendata/components/OpenDataHelpers';
import RollingStock2Img from 'applications/osrd/components/RollingStock/RollingStock2Img';
import RollingStock2Img from 'common/RollingStockSelector/RollingStock2Img';
import rollingstockOpenData2OSRD from './rollingstock_opendata2osrd.json';

export default function TrainDetail(props) {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React, { useState } from 'react';
import PropTypes from 'prop-types';
import InfraSelector from 'common/InfraSelector/InfraSelector';
import RollingStockSelector from 'applications/osrd/views/OSRDConfig/RollingStockSelector';
import RollingStockSelector from 'common/RollingStockSelector/RollingStockSelector';
import TimetableSelector from 'applications/osrd/views/OSRDConfig/TimetableSelector';
import { useTranslation } from 'react-i18next';
import { useSelector } from 'react-redux';
Expand Down
Loading

0 comments on commit a25c3bb

Please sign in to comment.