front: lmr: change default timePicker value to prevent e2e test from …

…failing Signed-off-by: SarahBellaha <[email protected]>
OpenRailAssociation · Dec 5, 2024 · a37ab89 · a37ab89
1 parent 3f02a11
commit a37ab89
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 11 deletions.
diff --git a/front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx b/front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx
@@ -37,9 +37,7 @@ type StdcmOpScheduleProps = {
 
 const defaultDate = (date?: Date) => {
   const newDate = date ? new Date(date) : new Date();
-  newDate.setHours(0);
-  newDate.setMinutes(0);
-  newDate.setSeconds(0);
+  newDate.setHours(0, 0, 0);
   return newDate;
 };
 
@@ -67,9 +65,9 @@ const StdcmOpSchedule = ({
           opTimingData && isArrivalDateValid
             ? new Date(opTimingData.arrivalDate)
             : defaultDate(searchDatetimeWindow?.begin),
-        arrivalTime: opTimingData?.arrivalTime || '--:--',
-        arrivalTimeHours: opTimingData?.arrivalTimehours,
-        arrivalTimeMinutes: opTimingData?.arrivalTimeMinutes,
+        arrivalTime: opTimingData?.arrivalTime || '00:00',
+        arrivalTimeHours: opTimingData?.arrivalTimehours || 0,
+        arrivalTimeMinutes: opTimingData?.arrivalTimeMinutes || 0,
         arrivalToleranceValues: {
           minusTolerance: opToleranceValues.arrivalToleranceBefore,
           plusTolerance: opToleranceValues.arrivalToleranceAfter,
@@ -106,11 +104,11 @@ const StdcmOpSchedule = ({
     ) {
       onArrivalChange({
         date: defaultDate(searchDatetimeWindow?.begin),
-        hours: arrivalTimeHours || 0,
-        minutes: arrivalTimeMinutes || 0,
+        hours: arrivalTimeHours,
+        minutes: arrivalTimeMinutes,
       });
     }
-  }, [searchDatetimeWindow]);
+  }, [searchDatetimeWindow, opScheduleTimeType]);
 
   return (
     <>

diff --git a/front/tests/pages/stdcm-page-model.ts b/front/tests/pages/stdcm-page-model.ts
@@ -315,7 +315,7 @@ class STDCMPage {
     await expect(this.dynamicOriginCh).toHaveValue('BV');
     await expect(this.originArrival).toHaveValue('preciseTime');
     await expect(this.dateOriginArrival).toHaveValue('17/10/24');
-    await expect(this.timeOriginArrival).toHaveValue('');
+    await expect(this.timeOriginArrival).toHaveValue('00:00');
     await expect(this.toleranceOriginArrival).toHaveValue('-30/+30');
     await this.dynamicOriginCh.selectOption('BC');
     await this.originArrival.selectOption('asSoonAsPossible');
@@ -340,7 +340,7 @@ class STDCMPage {
     await expect(this.toleranceDestinationArrival).not.toBeVisible();
     await this.destinationArrival.selectOption('preciseTime');
     await expect(this.dateDestinationArrival).toHaveValue('17/10/24');
-    await expect(this.timeDestinationArrival).toHaveValue('');
+    await expect(this.timeDestinationArrival).toHaveValue('00:00');
     await expect(this.toleranceDestinationArrival).toHaveValue('-30/+30');
     await this.dateDestinationArrival.fill('18/10/24');
     await this.timeDestinationArrival.click();