front: fix missing await statements for asynchronous calls

OpenRailAssociation · Dec 23, 2024 · cdfb5a8 · cdfb5a8
1 parent 63ef76e
commit cdfb5a8
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/front/.eslintrc b/front/.eslintrc
@@ -47,7 +47,6 @@
     "@typescript-eslint/no-unsafe-return": "error",
     "@typescript-eslint/no-unsafe-call": "error",
     "@typescript-eslint/non-nullable-type-assertion-style": "error",
-
     "@typescript-eslint/ban-types": [
       "error",
       {
@@ -154,6 +153,12 @@
       "rules": {
         "@typescript-eslint/no-explicit-any": ["error", { "fixToUnknown": true }]
       }
+    },
+    {
+      "files": ["tests/**/*.ts", "src/front/tests/**/*.tsx"],
+      "rules": {
+        "@typescript-eslint/no-floating-promises": "error"
+      }
     }
   ]
 }
diff --git a/front/tests/004-scenario-management.spec.ts b/front/tests/004-scenario-management.spec.ts
@@ -24,7 +24,7 @@ test.describe('Validate the Scenario creation workflow', () => {
   });
 
   test.afterAll('Delete the electrical profile', async () => {
-    deleteApiRequest(`/api/electrical_profile_set/${electricalProfileSet.id}/`);
+    await deleteApiRequest(`/api/electrical_profile_set/${electricalProfileSet.id}/`);
   });
 
   /** *************** Test 1 **************** */

diff --git a/front/tests/pages/op-simulation-settings-page-model.ts b/front/tests/pages/op-simulation-settings-page-model.ts
@@ -28,7 +28,7 @@ class OperationalStudiesSimulationSettingsPage {
   // Deactivate electrical profiles switch
   async deactivateElectricalProfile() {
     await this.electricalProfilesSwitch.setChecked(false, { force: true });
-    expect(this.electricalProfilesSwitch).not.toBeChecked();
+    await expect(this.electricalProfilesSwitch).not.toBeChecked();
   }
 
   async activateLinearMargin() {

diff --git a/front/tests/pages/op-timetable-page-model.ts b/front/tests/pages/op-timetable-page-model.ts
@@ -152,7 +152,7 @@ class OperationalStudiesTimetablePage extends CommonPage {
   // Verify that the imported train number is correct
   async verifyTrainCount(trainCount: number): Promise<void> {
     await this.page.waitForLoadState('networkidle');
-    expect(this.timetableTrains).toHaveCount(trainCount);
+    await expect(this.timetableTrains).toHaveCount(trainCount);
   }
 
   // Filter trains validity and verify their count

diff --git a/front/tests/pages/operational-studies-page-model.ts b/front/tests/pages/operational-studies-page-model.ts
@@ -99,7 +99,7 @@ class OperationalStudiesPage extends CommonPage {
   }
 
   async checkTrainHasBeenAdded() {
-    this.checkLastToastTitle(trainAddedTranslation);
+    await this.checkLastToastTitle(trainAddedTranslation);
   }
 
   async returnSimulationResult() {