Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: the lines on the GET are not contrasted enough #10663

Open
clarani opened this issue Feb 4, 2025 · 2 comments
Open

front: the lines on the GET are not contrasted enough #10663

clarani opened this issue Feb 4, 2025 · 2 comments
Assignees
@jacomyal
Labels
area:front Work on Standard OSRD Interface modules from:users Something reported directly by the users kind:enhancement Improvement of existing features

Comments

@clarani
Copy link
Contributor

clarani commented Feb 4, 2025 •
edited
Loading

Warning

#10662 should be solved before this one

What happened?

The lines on the GET are not contrasted enough.

Image

The color of the lines should be modified according to the new mockup
@clarani clarani added area:front Work on Standard OSRD Interface modules from:users Something reported directly by the users kind:enhancement Improvement of existing features labels Feb 4, 2025
@clarani
Copy link
Contributor Author

clarani commented Feb 4, 2025

@thibautsailly 😉

@thibautsailly
Copy link

Thank you for #10662 ! I'm still working on this on my end by refactoring Sketch symbols for the Space Time Diagram, and the gridlines colours might change on the way. I think I'll work with Alexis next week on this.

@jacomyal jacomyal self-assigned this Feb 17, 2025
jacomyal added a commit to OpenRailAssociation/osrd-ui that referenced this issue Feb 28, 2025
@jacomyal
ui-spacetimechart: upgrades time captions
fab8035 
This commit implements new designs from @thibautsailly, and addresses
issue OpenRailAssociation/osrd#10663.

Details:
- Updates styles matrices for time captions and graduations
- Adds date labels
- Adds new option `hideDates` to hide date labels, adds it to the
  options story
- Adds some margin around the time captions stage, so that captions of
  times right outside the stage are still visible while panning
- Fixes path labels when axis are swapped

Signed-off-by: Alexis Jacomy <[email protected]>
@jacomyal jacomyal mentioned this issue Feb 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacomyal jacomyal

Labels
area:front Work on Standard OSRD Interface modules from:users Something reported directly by the users kind:enhancement Improvement of existing features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jacomyal @thibautsailly @clarani