Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: lmr: remove grid margins #11020

Open
eckter opened this issue Mar 4, 2025 · 0 comments · May be fixed by #11044
Open

front: lmr: remove grid margins #11020

eckter opened this issue Mar 4, 2025 · 0 comments · May be fixed by #11044
Assignees
Labels
area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM

Comments

@eckter
Copy link
Contributor

eckter commented Mar 4, 2025

Apparently the grid margin is meant to estimate how long the signals must be green before they're passed by the train. But we already have an accurate estimation with the sight distance, something they don't have in contexts where grid margin is used. So we add two redundant margins and we end up too pessimistic.

We don't want to remove the feature (yet?), but we should set the default value to 0.

See #9984 for the last PR on this subject, we probably need to do the same kind of change again.

@eckter eckter self-assigned this Mar 4, 2025
@eckter eckter added area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM labels Mar 4, 2025
@eckter eckter linked a pull request Mar 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant