Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove grid margins #11044

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

front: remove grid margins #11044

wants to merge 1 commit into from

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Mar 6, 2025

They were redundant with the "green signal" requirements of our conflict detection module, we'd miss out on solutions for no good reason.

Fix #11020

They were redundant with the "green signal" requirements of
our conflict detection module, we'd miss out on solutions
for no good reason.

Signed-off-by: Eloi Charpentier <[email protected]>
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Mar 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (164c697) to head (1b57b83).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/reducers/osrdconf/stdcmConf/index.ts 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #11044      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.01%     
==========================================
  Files        1099     1101       +2     
  Lines      112187   112322     +135     
  Branches      745      749       +4     
==========================================
+ Hits        90460    90565     +105     
- Misses      21684    21714      +30     
  Partials       43       43              
Flag Coverage Δ
editoast 72.18% <ø> (-0.01%) ⬇️
front 89.92% <50.00%> (-0.03%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eckter eckter marked this pull request as ready for review March 6, 2025 11:17
@eckter eckter requested a review from a team as a code owner March 6, 2025 11:17
@eckter eckter requested a review from clarani March 6, 2025 13:17
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: lmr: remove grid margins
3 participants