-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: get paced train path endpoint #11051
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #11051 +/- ##
==========================================
+ Coverage 80.62% 80.65% +0.03%
==========================================
Files 1101 1101
Lines 112366 112406 +40
Branches 747 747
==========================================
+ Hits 90590 90662 +72
+ Misses 21733 21701 -32
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
45fbc42
to
081ee26
Compare
9d0ae7a
to
9365463
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem than #10945, can you update the commit's title to replace "endpont" with "endpoint" 🙏
Signed-off-by: Egor Berezovskiy <[email protected]>
9365463
to
bad1e42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Errors cases could be tested, otherwise LGTM, thansk!
let infra = Infra::retrieve_or_fail(conn, infra_id, || PacedTrainError::InfraNotFound { | ||
infra_id, | ||
}) | ||
.await?; | ||
let paced_train = PacedTrain::retrieve_or_fail(conn, paced_train_id, || { | ||
PacedTrainError::PacedTrainNotFound { paced_train_id } | ||
}) | ||
.await?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be tested
fix #11052
Part of https://github.com/osrd-project/osrd-confidential/issues/779
Implement a get paced train path endpoint