Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: update paced train endpoint #10945

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Feb 25, 2025

fix #10591

depend on #10842

@Wadjetz Wadjetz self-assigned this Feb 25, 2025
@github-actions github-actions bot added area:front Work on Standard OSRD Interface modules area:editoast Work on Editoast Service area:integration-tests Work on Integration test, by nature related to different services labels Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.17647% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (7d6c72a) to head (84f55a8).

Files with missing lines Patch % Lines
editoast/src/views/paced_train.rs 93.93% 2 Missing ⚠️
front/src/common/api/generatedEditoastApi.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #10945   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files        1101     1101           
  Lines      112322   112337   +15     
  Branches      749      749           
=======================================
+ Hits        90566    90588   +22     
+ Misses      21713    21706    -7     
  Partials       43       43           
Flag Coverage Δ
editoast 72.22% <93.93%> (+0.03%) ⬆️
front 89.92% <0.00%> (ø)
gateway 2.18% <ø> (ø)
osrdyne 2.53% <ø> (ø)
railjson_generator 87.58% <ø> (ø)
tests 87.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch from e9b0f60 to 773fbda Compare February 25, 2025 10:50
@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Feb 25, 2025
@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch from 773fbda to 83774fa Compare February 26, 2025 09:49
@github-actions github-actions bot removed the area:integration-tests Work on Integration test, by nature related to different services label Feb 26, 2025
@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch 3 times, most recently from abf4450 to 6e94dd6 Compare February 27, 2025 16:02
@github-actions github-actions bot removed the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Feb 27, 2025
@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch 2 times, most recently from 28812cc to 8d1c9c1 Compare March 4, 2025 12:44
@@ -128,6 +129,43 @@ async fn get_by_id(
Ok(Json(paced_train))
}

/// Update a train schedule and its result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// Update a train schedule and its result
/// Update a paced train and its result

what is the "result" referring to?

params(PacedTrainIdParam),
request_body = inline(PacedTrainBase),
responses(
(status = 204, body = PacedTrainResult, description = "Paced train have been updated")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

204 with a content? 🤔

@Wadjetz Wadjetz marked this pull request as ready for review March 4, 2025 13:39
@Wadjetz Wadjetz requested a review from a team as a code owner March 4, 2025 13:39
@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch 3 times, most recently from f1d1902 to eabc899 Compare March 4, 2025 17:54
@Wadjetz Wadjetz requested a review from leovalais March 5, 2025 09:42
@woshilapin woshilapin changed the title editoast: update paced train endpont editoast: update paced train endpoint Mar 5, 2025
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the commit's title has a typo ("endpont" instead of "endpoint"), could you fix that please? 🙏

@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch 2 times, most recently from 50f5f50 to add8e55 Compare March 6, 2025 12:48
@Wadjetz Wadjetz force-pushed the ebe/editoast/update-paced-train branch from add8e55 to 84f55a8 Compare March 6, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update a paced train endpoint
4 participants