-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: update paced train endpoint #10945
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10945 +/- ##
=======================================
Coverage 80.63% 80.63%
=======================================
Files 1101 1101
Lines 112322 112337 +15
Branches 749 749
=======================================
+ Hits 90566 90588 +22
+ Misses 21713 21706 -7
Partials 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e9b0f60
to
773fbda
Compare
773fbda
to
83774fa
Compare
abf4450
to
6e94dd6
Compare
28812cc
to
8d1c9c1
Compare
editoast/src/views/paced_train.rs
Outdated
@@ -128,6 +129,43 @@ async fn get_by_id( | |||
Ok(Json(paced_train)) | |||
} | |||
|
|||
/// Update a train schedule and its result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// Update a train schedule and its result | |
/// Update a paced train and its result |
what is the "result" referring to?
editoast/src/views/paced_train.rs
Outdated
params(PacedTrainIdParam), | ||
request_body = inline(PacedTrainBase), | ||
responses( | ||
(status = 204, body = PacedTrainResult, description = "Paced train have been updated") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
204 with a content? 🤔
f1d1902
to
eabc899
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, the commit's title has a typo ("endpont" instead of "endpoint"), could you fix that please? 🙏
50f5f50
to
add8e55
Compare
Signed-off-by: Egor Berezovskiy <[email protected]>
add8e55
to
84f55a8
Compare
fix #10591
depend on #10842