Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite STDCM Allowances component #4918

Closed
nicolaswurtz opened this issue Aug 29, 2023 · 0 comments · Fixed by #4938
Closed

Rewrite STDCM Allowances component #4918

nicolaswurtz opened this issue Aug 29, 2023 · 0 comments · Fixed by #4938
Assignees
Labels
area:front Work on Standard OSRD Interface modules

Comments

@nicolaswurtz
Copy link
Contributor

STDCM Allowances were based on old allowances component from operational studies.
STDCM just needs 3 input fields to enter allowances settings, so it would be straightforward to implement a lightweight solution rather than use a huge component.

New component must give the same functionalities as today but be entierely new.
It has to propose 3 input fields :

  • margin before
  • margin after
  • global allowance (% or min/100)

It should use the already existing components from OSRD InputSNCF for the two first fields, and InputGroupSNCF for the last field. Implementation from new allowance component from operational studies could be a good reference, but no dependence will be tolerated.

OldAllowances folder will be fully destroyed and thrown into the abyss of the void at the end of this refactoring process.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants