Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different modals and different ux for map layers modals #5306

Closed
bloussou opened this issue Oct 12, 2023 · 4 comments · Fixed by #5607
Closed

Different modals and different ux for map layers modals #5306

bloussou opened this issue Oct 12, 2023 · 4 comments · Fixed by #5607
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working kind:enhancement Improvement of existing features module:carto OSRD mapviz standard module module:infra-editor Infra Edition severity:minor Minor severity bug

Comments

@bloussou
Copy link
Contributor

What happened?

In the infrastructure editor you must validate once radio button are activated
image
it is not the case on the map
image

What did you expect to happen?

Not to have to validate the choices, it is redundant and not user friendly

How can we reproduce it (as minimally and precisely as possible)?

.

What operating system, browser and environment are you using?

firefox

OSRD version (top right corner Account button > Informations)

e32e129
@bloussou bloussou added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:carto OSRD mapviz standard module module:infra-editor Infra Edition labels Oct 12, 2023
@Castavo Castavo added the severity:minor Minor severity bug label Oct 13, 2023
@Castavo
Copy link
Contributor

Castavo commented Oct 13, 2023

Is it not more a feature change than a bug ?

@axrolld axrolld added the kind:enhancement Improvement of existing features label Oct 26, 2023
@axrolld
Copy link
Contributor

axrolld commented Oct 26, 2023

I'm considering this as an enhancement, but i think we should fix this before v1

@SarahBellaha SarahBellaha mentioned this issue Nov 6, 2023
Merged
@SarahBellaha SarahBellaha self-assigned this Nov 6, 2023
@SarahBellaha SarahBellaha linked a pull request Nov 7, 2023 that will close this issue
front: rework layer activation #5607
Merged
@flomonster
Copy link
Contributor

The modals are still different. Even if the content is closer, isn't it possible to use the same modal?

@flomonster flomonster reopened this Nov 23, 2023
@flomonster
Copy link
Contributor

Since it requires a huge code refactoring we won't consider this as a small bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working kind:enhancement Improvement of existing features module:carto OSRD mapviz standard module module:infra-editor Infra Edition severity:minor Minor severity bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

front: rework layer activation OpenRailAssociation/osrd
5 participants
@flomonster @bloussou @Castavo @axrolld @SarahBellaha