front: rework layer activation #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahBellaha
added
kind:bug
Codecov Report
@@ Coverage Diff @@
## dev #5607 +/- ##
=========================================
Coverage 19.57% 19.57%
Complexity 2322 2322
=========================================
Files 886 886
Lines 105832 105818 -14
Branches 2572 2572
=========================================
Hits 20716 20716
+ Misses 83607 83593 -14
Partials 1509 1509
Flags with carried forward coverage won't be shown. Click here to find out more.
|
SharglutDev
requested changes
Nov 7, 2023
There was a problem hiding this comment.
Thank you for this PR !
Noticed some problems while testing :
- on left panel, when opening the electrification or speed limit form (which are not rendered like the rest of the editor), the layer is not activated. In fact, it seems to hide all the current activated layers.
- if the layer pops when toggling the switch. Is it still relevant to have the cancel and confirm button ?
- in the layers modal, we can for example activate the signal layer without the track section layer whereas this behavior is different when clicking in the left panel (track sections seems to be required to display signals)
SarahBellaha
force-pushed
the
sba/front/rework-layer-activation
branch
from
313c555 to
a9f622f
Compare
SharglutDev
requested changes
Nov 9, 2023
front/src/applications/editor/tools/rangeEdition/catenary/CatenaryEditionLayers.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/catenary/CatenaryEditionLayers.tsx
Outdated
Show resolved
Hide resolved
SharglutDev
requested changes
Nov 9, 2023
front/src/applications/editor/tools/rangeEdition/speedSection/SpeedSectionEditionLayers.tsx
Outdated
Show resolved
Hide resolved
front/src/applications/editor/tools/rangeEdition/speedSection/SpeedSectionEditionLayers.tsx
Outdated
Show resolved
Hide resolved
SarahBellaha
force-pushed
the
sba/front/rework-layer-activation
branch
2 times, most recently
from
95ac784 to
dad9c1c
Compare
|
Seen with PO, we can remove the "Confirm" and "Cancel" button from the layers modal |
SarahBellaha
force-pushed
the
sba/front/rework-layer-activation
branch
from
16f64c5 to
0a724fd
Compare
SharglutDev
approved these changes
Nov 13, 2023
clarani
reviewed
Nov 13, 2023
SarahBellaha
force-pushed
the
sba/front/rework-layer-activation
branch
from
4b9716f to
43e9d5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5483
Closes #5593 (same as #5306)
Closes #5644