Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: refactor SignalProjection and ScheduleMetadataExtractor inputs #5526

Open
eckter opened this issue Oct 30, 2023 · 0 comments
Open

core: refactor SignalProjection and ScheduleMetadataExtractor inputs #5526

eckter opened this issue Oct 30, 2023 · 0 comments
Labels
area:core Work on Core Service

Comments

@eckter
Copy link
Contributor

eckter commented Oct 30, 2023

#5515 was a "quick and dirty" fix, it should be reverted and the inputs of the classes should be refactored.

They should take blocks as inputs instead of computing the blocks from the route ids. The block path should include begin/end offsets. The routes should be computed from the blocks.

@eckter eckter added the area:core Work on Core Service label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service
Projects
None yet
Development

No branches or pull requests

1 participant