Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rolling stock supported signaling systems #6578

Closed
flomonster opened this issue Feb 6, 2024 · 0 comments · Fixed by #6590
Closed

Cleanup rolling stock supported signaling systems #6578

flomonster opened this issue Feb 6, 2024 · 0 comments · Fixed by #6590
Assignees
Labels
area:editoast Work on Editoast Service kind:enhancement Improvement of existing features

Comments

@flomonster
Copy link
Contributor

flomonster commented Feb 6, 2024

Description

The signaling system list should be considered as dynamic information loaded from "extension".

Editoast validates the supported_signaling_systems using an enum which is not valid.

What should be done?

  1. Remove the enum: https://github.com/osrd-project/osrd/blob/5895b8726a4f1969fdcd922404ac7aa2e388dcb2/editoast/src/schema/rolling_stock/mod.rs#L268-L277
  2. Replace where the enum was used by Vec<String>
  3. Remove the feature unused field:
  • Make a migration
  • Adapt editoast
  • Adapt core
  • Adapt python osrd_schemas
@flomonster flomonster added the area:editoast Work on Editoast Service label Feb 6, 2024
@flomonster flomonster added the kind:enhancement Improvement of existing features label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:enhancement Improvement of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants