-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup rollingstock model #6590
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #6590 +/- ##
============================================
- Coverage 28.01% 26.95% -1.06%
Complexity 2170 2170
============================================
Files 1032 987 -45
Lines 127750 125597 -2153
Branches 2603 2618 +15
============================================
- Hits 35783 33859 -1924
+ Misses 90452 90209 -243
- Partials 1515 1529 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f05ae0b
to
e14864a
Compare
e14864a
to
ae5b4dc
Compare
ae5b4dc
to
cc883e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on core / python
(there's a flake8 error to be fixed first though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the frontend part
Maybe you should merge your 2 commits into 1 |
cc883e3
to
ee00460
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (review and tested). Only one suggestion to simplify migrations.
editoast/migrations/2024-02-06-171107_remove_features_from_rollingstock/up.sql
Outdated
Show resolved
Hide resolved
editoast/migrations/2024-02-06-171107_remove_features_from_rollingstock/down.sql
Outdated
Show resolved
Hide resolved
76672d2
to
5644df5
Compare
… remove SignalingSystem enum
5644df5
to
961c5f4
Compare
closes #6578