Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup rollingstock model #6590

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

SarahBellaha
Copy link
Contributor

closes #6578

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1372f0a) 28.01% compared to head (961c5f4) 26.95%.
Report is 10 commits behind head on dev.

Files Patch % Lines
...tock/components/RollingStockSelector/sampleData.ts 0.00% 1 Missing ⚠️
front/src/modules/rollingStock/helpers/utils.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6590      +/-   ##
============================================
- Coverage     28.01%   26.95%   -1.06%     
  Complexity     2170     2170              
============================================
  Files          1032      987      -45     
  Lines        127750   125597    -2153     
  Branches       2603     2618      +15     
============================================
- Hits          35783    33859    -1924     
+ Misses        90452    90209     -243     
- Partials       1515     1529      +14     
Flag Coverage Δ
core 78.54% <ø> (+0.01%) ⬆️
editoast 75.34% <100.00%> (-0.01%) ⬇️
front 8.64% <50.00%> (+0.02%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator ?
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SarahBellaha SarahBellaha force-pushed the sba-6578-cleanup-rollingstock-model branch from f05ae0b to e14864a Compare February 7, 2024 16:02
@anisometropie anisometropie force-pushed the sba-6578-cleanup-rollingstock-model branch from e14864a to ae5b4dc Compare February 8, 2024 08:52
@anisometropie anisometropie marked this pull request as ready for review February 8, 2024 08:58
@anisometropie anisometropie requested review from a team as code owners February 8, 2024 08:58
@anisometropie anisometropie requested a review from eckter February 8, 2024 08:58
@anisometropie anisometropie force-pushed the sba-6578-cleanup-rollingstock-model branch from ae5b4dc to cc883e3 Compare February 8, 2024 09:02
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on core / python

(there's a flake8 error to be fixed first though)

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the frontend part

⚠️ you have a linter error which breaks the build

@clarani
Copy link
Contributor

clarani commented Feb 8, 2024

Maybe you should merge your 2 commits into 1

@anisometropie anisometropie force-pushed the sba-6578-cleanup-rollingstock-model branch from cc883e3 to ee00460 Compare February 8, 2024 09:30
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (review and tested). Only one suggestion to simplify migrations.

@flomonster flomonster changed the title cleanup rollingstock model Cleanup rollingstock model Feb 8, 2024
@SarahBellaha SarahBellaha force-pushed the sba-6578-cleanup-rollingstock-model branch 2 times, most recently from 76672d2 to 5644df5 Compare February 8, 2024 11:10
@SarahBellaha SarahBellaha force-pushed the sba-6578-cleanup-rollingstock-model branch from 5644df5 to 961c5f4 Compare February 8, 2024 11:14
@anisometropie anisometropie added this pull request to the merge queue Feb 8, 2024
Merged via the queue into dev with commit 8f490e7 Feb 8, 2024
22 checks passed
@anisometropie anisometropie deleted the sba-6578-cleanup-rollingstock-model branch February 8, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup rolling stock supported signaling systems
6 participants