Cleanup rollingstock model

[SarahBellaha]

closes #6578

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1372f0a) 28.01% compared to head (961c5f4) 26.95%.
Report is 10 commits behind head on dev.

Files	Patch %	Lines
...tock/components/RollingStockSelector/sampleData.ts	0.00%	1 Missing ⚠️
front/src/modules/rollingStock/helpers/utils.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #6590      +/-   ##
============================================
- Coverage     28.01%   26.95%   -1.06%     
  Complexity     2170     2170              
============================================
  Files          1032      987      -45     
  Lines        127750   125597    -2153     
  Branches       2603     2618      +15     
============================================
- Hits          35783    33859    -1924     
+ Misses        90452    90209     -243     
- Partials       1515     1529      +14     

Flag	Coverage Δ
core	78.54% <ø> (+0.01%)	⬆️
editoast	75.34% <100.00%> (-0.01%)	⬇️
front	8.64% <50.00%> (+0.02%)	⬆️
gateway	2.50% <ø> (ø)
railjson_generator	?
tests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[eckter]

LGTM on core / python

(there's a flake8 error to be fixed first though)

[clarani]

LGTM for the frontend part

⚠️ you have a linter error which breaks the build

[clarani]

Maybe you should merge your 2 commits into 1

[flomonster]

LGTM (review and tested). Only one suggestion to simplify migrations.