Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: stdcm: pre-filter train requirements that can't affect the new train #7649

Closed
eckter opened this issue Jun 6, 2024 · 0 comments · Fixed by #8091
Closed

editoast: stdcm: pre-filter train requirements that can't affect the new train #7649

eckter opened this issue Jun 6, 2024 · 0 comments · Fixed by #8091
Assignees
Labels
area:editoast Work on Editoast Service difficulty:good first issue Good for newcomers kind:enhancement Improvement of existing features module:stdcm Short-Term DCM

Comments

@eckter
Copy link
Contributor

eckter commented Jun 6, 2024

When editoast build the stdcm request to be sent to core, it fetches all the train requirements for the scheduled trains. See here

At this point, we know when the train is supposed to start and when it will end (based on max running time). We could easily pre-filter the train requirements to only include the ones in this window.

It would make the request smaller (they're currently around 20MB for an imported timetable), and it would speed some things up in core. We could do the filtering on the core side, but we'd miss out on the request size reduction.

It's a prerequisite for stdcm requests in timetables that span over more than a few hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service difficulty:good first issue Good for newcomers kind:enhancement Improvement of existing features module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant