editoast: stdcm: add arrival time parameters #7827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7827 +/- ##
============================================
- Coverage 28.55% 28.54% -0.01%
Complexity 2059 2059
============================================
Files 1249 1249
Lines 154130 154183 +53
Branches 3040 3041 +1
============================================
+ Hits 44006 44011 +5
- Misses 108310 108358 +48
Partials 1814 1814
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/stdcm-add-arrival-times
branch
from
623f333 to
1ede6d0
Compare
SharglutDev
requested review from
kmer2016 and
SarahBellaha
and removed request for
SharglutDev
flomonster
requested changes
Jun 25, 2024
eckter
force-pushed
the
ech/stdcm-add-arrival-times
branch
3 times, most recently
from
24176d7 to
6d39b82
Compare
flomonster
approved these changes
Jun 27, 2024
eckter
force-pushed
the
ech/stdcm-add-arrival-times
branch
from
6d39b82 to
0677bce
Compare
kmer2016
approved these changes
Jun 27, 2024
eckter
force-pushed
the
ech/stdcm-add-arrival-times
branch
from
0677bce to
12a5a59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7692 and #7687
Adds stop time parameters and forwards them from editoast inputs to core. Departure time parameter is now optional.
There's a few other changes on the editoast side to have meaningful values as start/end times despite this change. Eventually we should use them to pre-filter the resource uses (see #7649).
There's one API change on which I'm not 100% sure: I've "deprecated" the departure time parameter, assuming the time of the first waypoint should be used instead. We could instead keep it but not let the user set a time for the first waypoint.
Note: the feature is not entirely supported by core yet. When the departure time is set, the behavior won't change. If it's not set, the departure time will be too early and the scheduled points will be ignored, but it won't crash.