Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: display the via added by click on the map in the manchette #8174

Closed
2 tasks
clarani opened this issue Jul 25, 2024 · 2 comments · Fixed by #8698 or #8852
Closed
2 tasks

front: display the via added by click on the map in the manchette #8174

clarani opened this issue Jul 25, 2024 · 2 comments · Fixed by #8698 or #8852
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:major Major severity bug

Comments

@clarani
Copy link
Contributor

clarani commented Jul 25, 2024

What happened?

When the train path doesn't cover at least two operational points, nothing is displayed. It's an edge case but it feels wrong

This is because the vias added by clicking on the map are not displayed on the chart. We should add them with the operational points.

What did you expect to happen?

  • the via added by clicking on the map are displayed
  • if a train doesn't cover 2 operational points, the space time chart is displayed

How can we reproduce it (as minimally and precisely as possible)?

  1. Go to a scenario v2
  2. Add a train by clicking on the map, set the origin and destination on the same track (try to choose a track without any op)
  3. Visualize the results of the simulation: the space time chart is not displayed

On which environments the bug occurs?

No response

On which browser the bug occurs?

No response

OSRD version (top right corner Account button > Informations)

.

@clarani clarani added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules severity:major Major severity bug labels Jul 25, 2024
@clarani clarani changed the title front: display the via added by click on the map front: display the via added by click on the map in the manchette Jul 26, 2024
@SharglutDev SharglutDev self-assigned this Sep 2, 2024
@SharglutDev
Copy link
Contributor

SharglutDev commented Sep 6, 2024

As requested by @thibautsailly, the waypoints added by map click should be named request point (x) / point demandé (x) with no capital case and in parenthesis the number of "map clicked waypoint" (not depending if there is a constraint on it or if it's just a waypoint).

The parenthesis is, for now, to "simulate" a circle to stay close to the behavior in the itinerary tab in operational studies where we have a dashed circle before each waypoints.
Capture d’écran 2024-09-06 à 14 50 41

@Tguisnet Tguisnet reopened this Sep 12, 2024
@Tguisnet
Copy link
Contributor

Tguisnet commented Sep 12, 2024

I think the bug is not completly fix :

  • "if a train doesn't cover 2 operational points, the space time chart is displayed" is not fully functionnal
    If we have 0 OPs, the space time chart is not display

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working severity:major Major severity bug
Projects
None yet
3 participants