Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: manchette: display waypoints added with map click #8698

Merged
merged 1 commit into from
Sep 6, 2024
Merged

front: manchette: display waypoints added with map click #8698

merged 1 commit into from
Sep 6, 2024

Conversation

SharglutDev
Copy link
Contributor

fix #8174

@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 37.00%. Comparing base (d261967) to head (b41838d).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...TimeChart/useGetProjectedTrainOperationalPoints.ts 0.00% 53 Missing ⚠️
...ations/operationalStudies/hooks/useScenarioData.ts 0.00% 6 Missing ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 4 Missing ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #8698      +/-   ##
============================================
- Coverage     37.03%   37.00%   -0.04%     
  Complexity     2208     2208              
============================================
  Files          1255     1255              
  Lines        113915   113969      +54     
  Branches       3188     3188              
============================================
- Hits          42192    42176      -16     
- Misses        69828    69898      +70     
  Partials       1895     1895
Flag Coverage Δ
core 74.75% <ø> (ø)
editoast 72.14% <ø> (-0.06%) ⬇️
front 14.95% <0.00%> (-0.02%) ⬇️
gateway 2.20% <ø> (ø)
osrdyne 2.71% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 86.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/manchette/display-all-waypoints branch from 3ca0d01 to e952eb8 Compare September 4, 2024 07:49
@SharglutDev SharglutDev marked this pull request as ready for review September 4, 2024 07:50
@SharglutDev SharglutDev requested a review from a team as a code owner September 4, 2024 07:50
@SharglutDev SharglutDev requested a review from emersion September 5, 2024 12:38
@SharglutDev SharglutDev force-pushed the pfn/front/manchette/display-all-waypoints branch from 34ee92d to 48f12d2 Compare September 5, 2024 16:08
emersion
emersion approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@emersion emersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With that extraneous file removed, LGTM! Thanks for the fix!

@SharglutDev SharglutDev force-pushed the pfn/front/manchette/display-all-waypoints branch from 71808d1 to 6fe48ce Compare September 5, 2024 16:39
@SharglutDev
Copy link
Contributor Author

With that extraneous file removed, LGTM! Thanks for the fix!

Yep my bad -_-

Math-R
Math-R approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@SharglutDev SharglutDev force-pushed the pfn/front/manchette/display-all-waypoints branch from b745e1b to b41838d Compare September 6, 2024 09:55
@SharglutDev SharglutDev added this pull request to the merge queue Sep 6, 2024
Merged via the queue into dev with commit 3feddac Sep 6, 2024
22 checks passed
@SharglutDev SharglutDev deleted the pfn/front/manchette/display-all-waypoints branch September 6, 2024 10:23
emersion added a commit that referenced this pull request Sep 10, 2024
@emersion
front: replace some type assertions with non-null assertions
bad1972 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
@emersion emersion mentioned this pull request Sep 10, 2024
Merged
emersion added a commit that referenced this pull request Sep 10, 2024
@emersion
front: replace some type assertions with non-null assertions
407ab23 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
emersion added a commit that referenced this pull request Sep 13, 2024
@emersion
front: replace some type assertions with non-null assertions
e9ac63b 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
emersion added a commit that referenced this pull request Sep 16, 2024
@emersion
front: replace some type assertions with non-null assertions
1386ba8 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
emersion added a commit that referenced this pull request Sep 16, 2024
@emersion
front: replace some type assertions with non-null assertions
e6a7912 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
github-merge-queue bot pushed a commit that referenced this pull request Sep 16, 2024
@emersion
front: replace some type assertions with non-null assertions
f210693 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
EthanPERRUZZA pushed a commit that referenced this pull request Sep 25, 2024
@emersion @EthanPERRUZZA
front: replace some type assertions with non-null assertions
1d30893 
In general I prefer to avoid `as` type assertions as much as
possible, because it makes the compiler ignore any type mismatch.
The non-null assertion operator `!` is a bit better: if the types
don't match, the compiler will error out.

Use it in a bunch of places.

See #8698 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Math-R Math-R Math-R approved these changes

@emersion emersion Awaiting requested review from emersion

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: display the via added by click on the map in the manchette
4 participants
@SharglutDev @codecov-commenter @emersion @Math-R