Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, editoast: add requirements field to conflict list #8680

Closed
emersion opened this issue Sep 2, 2024 · 1 comment · Fixed by #8758
Closed

core, editoast: add requirements field to conflict list #8680

emersion opened this issue Sep 2, 2024 · 1 comment · Fixed by #8758
Assignees
Labels
area:core Work on Core Service area:editoast Work on Editoast Service kind:enabler-task Enabler Story

Comments

@emersion
Copy link
Member

emersion commented Sep 2, 2024

Description and goal

Return a new requirements field in the conflict list:

- conflict_type: Spacing
  train_ids: [0, 1]
  start_time: "2024-08-07T08:50:17.421Z"
  duration: 120_000 # ms
  requirements:
    - time_range: [0, 50_000]
      # Core uses routing_requirements and spacing_requirements to deduce zones
      zones: ["zone_1", "zone_2"]
    - time_range: [45_000, 120_000]
      zones: ["zone_3"]

Acceptance criteria

.

@emersion emersion added area:core Work on Core Service area:editoast Work on Editoast Service kind:enabler-task Enabler Story labels Sep 2, 2024
@emersion emersion self-assigned this Sep 2, 2024
@emersion
Copy link
Member Author

emersion commented Sep 5, 2024

After discussion with @flomonster and @Erashin, we've concluded that we don't need to store multiple zones per requirement entry.

emersion added a commit that referenced this issue Sep 10, 2024
emersion added a commit that referenced this issue Sep 10, 2024
emersion added a commit that referenced this issue Sep 16, 2024
emersion added a commit that referenced this issue Sep 17, 2024
emersion added a commit that referenced this issue Sep 17, 2024
emersion added a commit that referenced this issue Sep 17, 2024
emersion added a commit that referenced this issue Sep 17, 2024
emersion added a commit that referenced this issue Sep 17, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 17, 2024
EthanPERRUZZA pushed a commit that referenced this issue Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core Work on Core Service area:editoast Work on Editoast Service kind:enabler-task Enabler Story
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant