Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: log and make E2E tests fail on uncaught exceptions #8883

Open
emersion opened this issue Sep 16, 2024 · 4 comments · May be fixed by #10004
Open

front: log and make E2E tests fail on uncaught exceptions #8883

emersion opened this issue Sep 16, 2024 · 4 comments · May be fixed by #10004
Assignees
Labels
area:front Work on Standard OSRD Interface modules

Comments

@emersion emersion added the area:front Work on Standard OSRD Interface modules label Sep 16, 2024
@Maymanaf
Copy link
Contributor

It's true that we currently lack detailed logs when an E2E test fails, but for now, we can review the screen recordings and trace files available in the CI artifacts.

Planned Solution: We will implement a new reporter (Allure Report) and integrate custom logs for each test.

⚠️ This task is not prioritized at the moment

@emersion
Copy link
Member Author

I don't think changing the reporter would help. Even if it reports uncaught exceptions (does it?), tests triggering uncaught exceptions would still succeed (but we want these to fail).

@Maymanaf
Copy link
Contributor

As you mentioned in the ticket, we can use pageerror to handle uncaught exceptions. However, these need to be customized and clearly defined, which is why we're considering a different reporting approach.
That said, I can add a non-optimized solution to fail the tests. Did you notice many uncaught exceptions not failing the tests?

@Maymanaf Maymanaf self-assigned this Dec 10, 2024
@Maymanaf Maymanaf linked a pull request Dec 10, 2024 that will close this issue
@emersion
Copy link
Member Author

Has this been closed by mistake? The PR hasn't been merged yet.

@emersion emersion reopened this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants