front: handle uncaught exceptions for e2e tests #10004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
from
6413f57 to
f8b5feb
Compare
Maymanaf
changed the title
emersion
previously approved these changes
Dec 10, 2024
Yohh
approved these changes
Dec 12, 2024
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
from
f8b5feb to
e433449
Compare
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
from
e433449 to
df9640b
Compare
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
3 times, most recently
from
d8d5afc to
12fd024
Compare
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
2 times, most recently
from
35d1cf4 to
1bfe55b
Compare
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
from
02bea96 to
892e22e
Compare
emersion
reviewed
Mar 7, 2025
| @@ -117,6 +120,7 @@ class ViaSection extends STDCMPage { | |||
| await this.getViaType(viaNumber).selectOption(SERVICE_STOP); | |||
| await expect(this.getViaStopTime(viaNumber)).toHaveValue(serviceStop.default); | |||
| await this.getViaStopTime(viaNumber).fill(serviceStop.input); | |||
| await this.page.waitForTimeout(EXPLICIT_UI_STABILITY_TIMEOUT); // Wait for the animation to complete | |||
There was a problem hiding this comment.
Could we replace this with scrollIntoViewIfNeeded(), which waits for the element to be stable? Or listen for the animationend event?
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
2 times, most recently
from
0c24fc7 to
8450dca
Compare
Signed-off-by: maymanaf <[email protected]>
Signed-off-by: maymanaf <[email protected]>
Signed-off-by: maymanaf <[email protected]>
Signed-off-by: maymanaf <[email protected]>
Maymanaf
force-pushed
the
aba/e2e-log-uncaught-exceptions
branch
from
8450dca to
9733d49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8883
NOT READY FOR REVEIW