Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margin bugs and input row deletion bugs #8959

Closed
louisgreiner opened this issue Sep 23, 2024 · 1 comment · Fixed by #9823
Closed

Margin bugs and input row deletion bugs #8959

louisgreiner opened this issue Sep 23, 2024 · 1 comment · Fixed by #9823
Assignees
Labels
area:front Work on Standard OSRD Interface modules component:schedule-table kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug

Comments

@louisgreiner
Copy link
Contributor

louisgreiner commented Sep 23, 2024

What happened?

I.
Margin of 0min/100km still computes margin

image

II.
No margin defined (input table):
image

But still, some margins are somehow displayed (output table):
image

III.
Input departure time is bugged when try to update an existing value

Enregistrement.de.l.ecran.2024-09-20.161545.mp4

IV.
Multi selected fields modification is bugged

Enregistrement.de.l.ecran.2024-09-20.170606.mp4

V.
Delete the value of a stopping time field behaves weirdly
(cf. previous video)

What did you expect to happen?

No response

How can we reproduce it (as minimally and precisely as possible)?

  1. open input table
  2. play with it
  3. open output table

On which environments the bug occurs?

Recette (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

staging fbf8e3e

@louisgreiner louisgreiner added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug component:schedule-table labels Sep 23, 2024
@Synar
Copy link
Contributor

Synar commented Oct 24, 2024

Issue II solved in #9375

Edit : One exception is for the departure, where a theoretical margin of 0% seems to be assumed by the sim, despite not being defined in the input table. Is this what we want?

Edit edit: Actually when deleted, the theoretial margin for the departure is autoset to 0%, but values of 0% are then hidden. Since there is still a defined value for the th margin, the other margins are then displayed. I don't know whether this is working as intended or not.

@Synar Synar self-assigned this Oct 24, 2024
@Synar Synar changed the title Margin Margin bugs and input row deletion bugs Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules component:schedule-table kind:bug Something isn't working module:operational-studies Multi-train simulation with structured studies management severity:major Major severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants