front: update timestop table

[Synar]

Close #9352

A few points (name of the CI column, width of each column, text boldness and color in the ch column) remain open in the issue, and will be patched in this PR as soon as they are clarified. All other aspects should be implemented.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 39.74%. Comparing base (f7f1991) to head (701cc5c).
Report is 3 commits behind head on dev.

Files with missing lines	Patch %	Lines
...c/modules/timesStops/hooks/useTimeStopsColumns.tsx	0.00%	50 Missing ⚠️
front/src/modules/timesStops/TimesStopsOutput.tsx	0.00%	3 Missing ⚠️
front/src/modules/timesStops/TimesStops.tsx	0.00%	2 Missing ⚠️
...ons/operationalStudies/views/SimulationResults.tsx	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #9375      +/-   ##
============================================
- Coverage     39.77%   39.74%   -0.03%     
  Complexity     2270     2270              
============================================
  Files          1302     1302              
  Lines         99565    99593      +28     
  Branches       3282     3282              
============================================
- Hits          39599    39584      -15     
- Misses        58034    58077      +43     
  Partials       1932     1932              

Flag	Coverage Δ
core	75.06% <ø> (ø)
editoast	73.52% <ø> (-0.06%)	⬇️
front	10.19% <0.00%> (-0.01%)	⬇️
gateway	2.19% <ø> (ø)
osrdyne	3.28% <ø> (ø)
railjson_generator	87.49% <ø> (ø)
tests	86.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Synar]

The last commit hardcode the line breaks and thus split the translations in 2, but I would rather revert this change

[clarani]

• Can you set the correct background color ? (behind the table)
• the 3 first columns are not in the right order (see the mockup)

[Synar]

Done ^^

[theocrsb]

Thank you for this PR. I've posted a few comments

[theocrsb]

The name of the output table should be added:

[Synar]

The name of the output table should be added

I was not sure whether the name was included in the table and thus the desired changes, but I don't mind adding it

[theocrsb]

The font size is 14 everywhere except the header, which has a font size of 12px

[Synar]

The name of the output table should be added

I was not sure whether the name was included in the table and thus the desired changes, but I don't mind adding it

Thibaut is a bit busy right now so I don't want to bother him for that, but for now I have added a title in line with the information and style already on the page

[Synar]

Good catch on the font size thanks, I did not think to check it

[theocrsb]

I can't see the CI anymore when I try to modify a train

[Synar]

I can't see the CI anymore when I try to modify a train

Good catch thanks, fixed, mb

[theocrsb]

Is the size of the CI column as expected?

[Synar]

Is the size of the CI column as expected?

I believe so, see thibaut comment on this in the issue. There should be a title tag to let you read the rest by hovering

[theocrsb]

Thibaut said CI values have a maximum of 35 characters for now
I think we don't have 35 characters.
#9352 (comment)

[Synar]

Maximum, not minimum

• All columns but CI have a fixed width based on (...)
• CI values have a maximum of 35 characters for now. (...)
• When the viewport is too small to display the whole CI value, a title tag should carry over. (...)

I have reduced the max width of the CI column btw, though this will be pushed later.
I discussed with thibaut and the title and units are fine as is, but we are going to make the durations right aligned (the times will stay left aligned, both for ease of comparison).
The headers in English, as well as a couple of French ones, will use abbreviations with title tags with the full values in order to both make column narrowers and reduce the height of the header.
Finally we may change the font of the min/100km unit, or otherwise find a way to make this column narrower.

[theocrsb]

I don't know if is this PR but we have a weird display in input table :

When we enter 0% we don't see anything displayed, but the array has kept a value.

And we see the two points

[Synar]

The fact that 0% values are hidden was already a hard coded behavior (in 2 different places, so clearly intentional). I don't understand why this is the case. I will discuss this with baptiste as soon as he's back, as well as other questions about margins displaying

Which column is the : with no seconds in?

[theocrsb]

The fact that 0% values are hidden was already a hard coded behavior (in 2 different places, so clearly intentional). I don't understand why this is the case. I will discuss this with baptiste as soon as he's back, as well as other questions about margins displaying

Which column is the : with no seconds in?

Ok. In Requested Arrival Time

[Synar]

I will remove the margins changes from this PR, to keep its scope more contained, and add them to another PR later (so until then the 0% will stay hidden, sorry).

I can not reproduce your bug about times being cut. Perhaps the column was simply too narrow? I can change the input table column width to make sure everything fits well.

[theocrsb]

I don't think we want to change the style of the input panel. (which would solve the problem of unseen seconds).

[clarani]

Almost good:

• can you make the column CI take all the remaining space ? So the table fills the whole page ?
  

• can you make the input table fill the whole space too in its tab ?
  

• can you rebase and solve the conflicts ?

[theocrsb]

LGTM and tested! Thank you for this PR

[clarani]

LGTM ✅