Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STDCM: Starting a new query does not reset all the fields in the consist card #9533

Closed
Maymanaf opened this issue Oct 31, 2024 · 7 comments
Closed
Assignees
Labels
area:front Work on Standard OSRD Interface modules difficulty:good first issue Good for newcomers kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug

Comments

@Maymanaf
Copy link
Contributor

What happened?

Image

What did you expect to happen?

The fields should be emptied

How can we reproduce it (as minimally and precisely as possible)?

  1. Go to stdcm, launch a request
  2. Select the simulation
  3. Click on reset the form

On which environments the bug occurs?

Recette (SNCF)

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

6d9ed21

@Maymanaf Maymanaf added area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug labels Oct 31, 2024
@Maymanaf Maymanaf added the difficulty:good first issue Good for newcomers label Nov 13, 2024
@axrolld
Copy link
Contributor

axrolld commented Nov 29, 2024

Sould be fixed by #9695

@celine-sncf
Copy link

Seems fixed for the "Convoi" card but still happening for the "Hour" field

@theocrsb
Copy link
Contributor

theocrsb commented Jan 8, 2025

I can't reproduce the bug

@sim51
Copy link
Contributor

sim51 commented Jan 8, 2025

I reproduce it for the "hour field".
In fact this field is also not changed when you switch from one simulation to an other.

I found a way to fix the "clean query" issue : in the component StdcmOpSchedule we pass to TimePicker the attribut value (as well as hours & minutes which are the good data). By removing it, it works.

But it doesn't fix my issue on simulation switch.

@theocrsb
Copy link
Contributor

theocrsb commented Jan 8, 2025

I reproduce it for the "hour field". In fact this field is also not changed when you switch from one simulation to an other.

I found a way to fix the "clean query" issue : in the component StdcmOpSchedule we pass to TimePicker the attribut value (as well as hours & minutes which are the good data). By removing it, it works.

But it doesn't fix my issue on simulation switch.

The bug when switch from one simulation to an other should be fix by this PR

sim51 added a commit that referenced this issue Jan 8, 2025
Related to #9533

TimePicker component should not have a `value` properety, it only needs
`hours`, `minutes` & `seconds`.

See OpenRailAssociation/osrd-ui#807 for more
informations

Signed-off-by: Benoit Simard <[email protected]>
@sim51
Copy link
Contributor

sim51 commented Jan 8, 2025

PR that fix the clear the hour field

sim51 added a commit that referenced this issue Jan 9, 2025
Related to #9533

TimePicker component should not have a `value` properety, it only needs
`hours`, `minutes` & `seconds`.

See OpenRailAssociation/osrd-ui#807 for more
informations

Signed-off-by: Benoit Simard <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Jan 9, 2025
Related to #9533

TimePicker component should not have a `value` properety, it only needs
`hours`, `minutes` & `seconds`.

See OpenRailAssociation/osrd-ui#807 for more
informations

Signed-off-by: Benoit Simard <[email protected]>
@EthanPERRUZZA EthanPERRUZZA self-assigned this Jan 21, 2025
@EthanPERRUZZA
Copy link
Contributor

PR were merged, bug is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules difficulty:good first issue Good for newcomers kind:bug Something isn't working module:stdcm Short-Term DCM severity:minor Minor severity bug
Projects
None yet
Development

No branches or pull requests

6 participants