-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lmr: front: pre-fill the total weight, length, and max speed of the consist when selecting traction engine and towed rs #9712
Comments
Note Missing (compo code; max speed) map for now Does it mean we don't take care of the compo code / max speed AC ? |
Leftover work in this issue #10016 |
We don't close the issue since the expected behavior is not clear for the update of values. For now, the value are NEVER updated after one changes it, but it is too restrictive. |
We still miss a work in progress feature from @Wadjetz. Maybe with it, this will be a little different ? (@maelysLeratRosso @Arthur-Lefebvre) |
The warnings will improve what we can explain to the user, yes. Here the question is : if the user writes something manually in one of these fields (length, weight, max speed), in which case do we authorize this field to be automatically updated if the default value changes (new traction engine for example) and on the contrary, when do we keep the value manually written by the user ? What we proposed with @thibautsailly is : Imagine a value is manually written for a field. Then this value can not be automatically updated UNLESS we are in one of these cases:
Of course you can call me to see examples if the text is not clear enough :) @axrolld You can veto if needed 😄 Note : For case 4, the warnings can later explain why we changed the value |
1, 2 and 3 make total sense to me :) For the 4., my understanding after some discussions with @thibautsailly (but maybe it was before yours) is that we don't want to erase an input that the user deliberately filled (and that's how we understood the issue for autofill). That's why we went for the warning option with @axrolld. |
You should not erase a value entered by the user as long as it's a coherent value. The message could be, for example, "the value 15m was not compatible with this traction engine, so we updated it". Not replacing the value would mean getting an error message after clicking the simulation button, which is less helpful to the user. |
Understood. Could you create an enhancement for that behavior ? :) We should have the time to deal with it before January 15th. |
I can create an enhancement. The information message, from what I understood, may come in a second part since it is not designed yet. But we can prepare the 4 cases and once we are ready for the information message, we add it ? |
We just discussed the information message with @thibautsailly, it's gonna come soon on the mockup and will probably be designed in this osrd-ui PR from @Wadjetz. |
The enhancement for the new behavior : https://github.com/osrd-project/osrd-confidential/issues/903 |
Description
Note
Missing (compo code; max speed) map for now
Pre-fill the total weight, length, and max speed of the consist when selecting traction engine and towed rolling stock.
AC
The text was updated successfully, but these errors were encountered: