-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fron: lmr consist prefill mass length max speed #9910
Conversation
2dd6457
to
cc5385a
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9910 +/- ##
==========================================
- Coverage 38.21% 38.19% -0.03%
==========================================
Files 992 992
Lines 92158 92191 +33
Branches 1186 1186
==========================================
- Hits 35221 35211 -10
- Misses 56486 56529 +43
Partials 451 451
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
910c294
to
db1d782
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR ! Almost good, left some comments
front/src/applications/stdcm/components/StdcmForm/StdcmConsist.tsx
Outdated
Show resolved
Hide resolved
db1d782
to
f53674e
Compare
Signed-off-by: Egor Berezovskiy <[email protected]>
f53674e
to
b207d7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm and tested, good job !
part of #9712
Prefill the consist values based on the rolling stock and towed rolling stock selection.
Do not update the value if the user has manually changed it.