Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fron: lmr consist prefill mass length max speed #9910

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Dec 2, 2024

part of #9712

Prefill the consist values based on the rolling stock and towed rolling stock selection.
Do not update the value if the user has manually changed it.

@Wadjetz Wadjetz added area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM labels Dec 2, 2024
@Wadjetz Wadjetz self-assigned this Dec 2, 2024
@Wadjetz Wadjetz force-pushed the ebe/front/lmr/prefill-mass-length-max-speed branch from 2dd6457 to cc5385a Compare December 2, 2024 10:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 8.82353% with 31 lines in your changes missing coverage. Please review.

Project coverage is 38.19%. Comparing base (02ccfc8) to head (b207d7c).
Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...nt/src/applications/stdcm/hooks/useStdcmConsist.ts 0.00% 24 Missing and 1 partial ⚠️
...ations/stdcm/components/StdcmForm/StdcmConsist.tsx 0.00% 3 Missing ⚠️
front/src/utils/physics.ts 60.00% 2 Missing ⚠️
...lications/stdcm/hooks/useStdcmTowedRollingStock.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9910      +/-   ##
==========================================
- Coverage   38.21%   38.19%   -0.03%     
==========================================
  Files         992      992              
  Lines       92158    92191      +33     
  Branches     1186     1186              
==========================================
- Hits        35221    35211      -10     
- Misses      56486    56529      +43     
  Partials      451      451              
Flag Coverage Δ
editoast 73.35% <ø> (-0.05%) ⬇️
front 20.18% <8.82%> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz marked this pull request as ready for review December 3, 2024 08:42
@Wadjetz Wadjetz requested a review from a team as a code owner December 3, 2024 08:42
@Wadjetz Wadjetz force-pushed the ebe/front/lmr/prefill-mass-length-max-speed branch 2 times, most recently from 910c294 to db1d782 Compare December 3, 2024 09:04
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR ! Almost good, left some comments

@Wadjetz Wadjetz force-pushed the ebe/front/lmr/prefill-mass-length-max-speed branch from db1d782 to f53674e Compare December 3, 2024 13:03
@Wadjetz Wadjetz requested a review from SharglutDev December 3, 2024 13:03
@Wadjetz Wadjetz force-pushed the ebe/front/lmr/prefill-mass-length-max-speed branch from f53674e to b207d7c Compare December 4, 2024 10:00
@Wadjetz Wadjetz requested a review from SharglutDev December 4, 2024 10:00
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested, good job !

@Wadjetz Wadjetz added this pull request to the merge queue Dec 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 4, 2024
@Wadjetz Wadjetz added this pull request to the merge queue Dec 4, 2024
@Wadjetz Wadjetz removed this pull request from the merge queue due to a manual request Dec 4, 2024
@Wadjetz Wadjetz added this pull request to the merge queue Dec 4, 2024
Merged via the queue into dev with commit 137c2dd Dec 4, 2024
27 checks passed
@Wadjetz Wadjetz deleted the ebe/front/lmr/prefill-mass-length-max-speed branch December 4, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants