Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front :margin input bug in timestops table #9882

Closed
Synar opened this issue Nov 27, 2024 · 0 comments · Fixed by #9867
Closed

front :margin input bug in timestops table #9882

Synar opened this issue Nov 27, 2024 · 0 comments · Fixed by #9867
Assignees
Labels
kind:bug Something isn't working severity:major Major severity bug

Comments

@Synar
Copy link
Contributor

Synar commented Nov 27, 2024

What happened?

If an invalid margin is entered in the timestopsinput table in the scenario page, the first correct margin that is entered to replace it is not taken into account (the margin is not saved and the corresponding op is not added to the path)

Screencast_20241127_180845.webm

In the above video, the 2 margins above the one being inputted were also entered on top of an invalid value and thus not actually saved, hence they disappear once I actually enter a value that updates the path

What did you expect to happen?

Every valid value gets taken into account, even if inputed after an invalid value

How can we reproduce it (as minimally and precisely as possible)?

-> Open the input table
-> Enter an invalid margin (e.g., "130" without a unit or "asd") on a row that is not in the path; the margin (correctly) turns red
-> Enter a valid margin instead; the margin returns to normal, but the row is not immediately added to the path, nor is the modification saved.

(See the video above)

On which environments the bug occurs?

Local

On which browser the bug occurs?

Firefox

OSRD version (top right corner Account button > Informations)

N/A

@Synar Synar added the kind:bug Something isn't working label Nov 27, 2024
@Synar Synar self-assigned this Nov 27, 2024
@Tguisnet Tguisnet added the severity:major Major severity bug label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working severity:major Major severity bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants