front: fix margin and improve stopfor input in timesstops table #9867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alice Khoudli <[email protected]>
Signed-off-by: Alice Khoudli <[email protected]>
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9867 +/- ##
==========================================
- Coverage 38.23% 38.21% -0.02%
==========================================
Files 995 995
Lines 91883 91881 -2
Branches 1189 1190 +1
==========================================
- Hits 35127 35115 -12
- Misses 56302 56312 +10
Partials 454 454
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Synar
changed the title
clarani
reviewed
Nov 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
clarani
deleted the
ali/fix-improve-margin-stopfor-input-in-timesstops-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit : fix bug where setting an invalid margin, then a valid margin, would not register the valid margin in the path
Close #9882
Second commit : enable the user to input timestops with second unit, which were otherwise silently discarded upon saving the table