Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: remove high speed train from stdcm #10018

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

axrolld
Copy link
Contributor

@axrolld axrolld commented Dec 11, 2024

Remove this high-speed train that sneaked among the freight locomotives.
It's just a kick fix i haven't checked that it actually works cause i can't deploy locally, but i assume this small fix should work. If you can try it quickly at the review i'd be great :)
Thanks !

@axrolld axrolld requested a review from a team as a code owner December 11, 2024 08:45
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.11%. Comparing base (9a10a58) to head (a47d7fe).
Report is 6 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10018      +/-   ##
==========================================
- Coverage   80.11%   80.11%   -0.01%     
==========================================
  Files        1048     1048              
  Lines      105250   105249       -1     
  Branches      756      756              
==========================================
- Hits        84326    84319       -7     
- Misses      20883    20889       +6     
  Partials       41       41              
Flag Coverage Δ
editoast 74.25% <ø> (-0.02%) ⬇️
front 89.36% <ø> (-0.01%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@axrolld axrolld added this pull request to the merge queue Dec 12, 2024
Merged via the queue into dev with commit f2d4da3 Dec 12, 2024
27 checks passed
@axrolld axrolld deleted the ard/front/rs-cleaning branch December 12, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants