Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default healthcheck timeout #10026

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

flomonster
Copy link
Contributor

This fixes a critical bug. Editoast was down because 500ms was not enough.

@flomonster flomonster requested a review from a team as a code owner December 12, 2024 10:53
@github-actions github-actions bot added the area:editoast Work on Editoast Service label Dec 12, 2024
@flomonster flomonster enabled auto-merge December 12, 2024 10:54
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.05%. Comparing base (f2d4da3) to head (c893fd9).
Report is 90 commits behind head on dev.

Files with missing lines Patch % Lines
editoast/src/client/runserver.rs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10026      +/-   ##
==========================================
+ Coverage   80.04%   80.05%   +0.01%     
==========================================
  Files        1049     1050       +1     
  Lines      105292   105423     +131     
  Branches      757      757              
==========================================
+ Hits        84277    84394     +117     
- Misses      20974    20988      +14     
  Partials       41       41              
Flag Coverage Δ
editoast 74.22% <0.00%> (-0.04%) ⬇️
front 89.25% <ø> (+0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@flomonster flomonster added this pull request to the merge queue Dec 19, 2024
Merged via the queue into dev with commit a0c8333 Dec 19, 2024
27 checks passed
@flomonster flomonster deleted the fam/increase-editoast-healthcheck-timeout branch December 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants