Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: update top positon of compass in map buttons #10080

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

theocrsb
Copy link
Contributor

closes https://github.com/osrd-project/osrd-confidential/issues/670

Check that the last button and the compass button are centered.

The 4px shift is that in the previous PR we used a 4px margin block and now simply an 8px margin bottom.

@theocrsb theocrsb requested a review from a team as a code owner December 13, 2024 14:49
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.80%. Comparing base (575dbe6) to head (518b9c4).
Report is 2 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10080      +/-   ##
==========================================
- Coverage   79.81%   79.80%   -0.01%     
==========================================
  Files        1052     1052              
  Lines      105434   105434              
  Branches      727      727              
==========================================
- Hits        84147    84138       -9     
- Misses      21245    21254       +9     
  Partials       42       42              
Flag Coverage Δ
editoast 73.71% <ø> (-0.03%) ⬇️
front 89.12% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM !

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested

@Akctarus Akctarus enabled auto-merge December 16, 2024 14:51
@theocrsb theocrsb force-pushed the tce/front/fix--wrong-display-button-map branch from 2ca492c to 518b9c4 Compare December 16, 2024 14:53
@Akctarus Akctarus added this pull request to the merge queue Dec 16, 2024
Merged via the queue into dev with commit c350ade Dec 16, 2024
27 checks passed
@Akctarus Akctarus deleted the tce/front/fix--wrong-display-button-map branch December 16, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants