Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemas: towed rolling stock max speed #10088

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Dec 16, 2024

part of #9637

Add towed rolling stock max speed to python osrd_schemas

@Wadjetz Wadjetz self-assigned this Dec 16, 2024
@github-actions github-actions bot added the area:railjson Work on Proposed Unified Rail Assets Data Exchange Format label Dec 16, 2024
@Wadjetz Wadjetz force-pushed the ebe/schemas/towed-rolling-stock-max-speed branch 2 times, most recently from d9d16f0 to d2be32b Compare December 16, 2024 10:38
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.89%. Comparing base (6ec445a) to head (2ce2214).
Report is 8 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #10088      +/-   ##
==========================================
- Coverage   79.90%   79.89%   -0.01%     
==========================================
  Files        1052     1052              
  Lines      105602   105602              
  Branches      759      759              
==========================================
- Hits        84381    84372       -9     
- Misses      21179    21188       +9     
  Partials       42       42              
Flag Coverage Δ
editoast 73.72% <ø> (-0.03%) ⬇️
front 89.25% <ø> (ø)
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz marked this pull request as ready for review December 16, 2024 12:24
@Wadjetz Wadjetz requested a review from a team as a code owner December 16, 2024 12:24
@Wadjetz Wadjetz force-pushed the ebe/schemas/towed-rolling-stock-max-speed branch from d2be32b to 2ce2214 Compare December 16, 2024 13:04
Copy link
Contributor

@Castavo Castavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I'm surprised this doesn't break anything in the CI, I guess we don't have any integration test involving towed rolling stock ... This is an issue for another PR

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I missed that, I believe it should have been done as part of #9654... but as said by Castavo, no CI step ensures that at the moment 🤷

@Wadjetz Wadjetz added this pull request to the merge queue Dec 16, 2024
Merged via the queue into dev with commit 6ecbfd2 Dec 16, 2024
27 checks passed
@Wadjetz Wadjetz deleted the ebe/schemas/towed-rolling-stock-max-speed branch December 16, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:railjson Work on Proposed Unified Rail Assets Data Exchange Format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants