-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemas: towed rolling stock max speed #10088
Conversation
d9d16f0
to
d2be32b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10088 +/- ##
==========================================
- Coverage 79.90% 79.89% -0.01%
==========================================
Files 1052 1052
Lines 105602 105602
Branches 759 759
==========================================
- Hits 84381 84372 -9
- Misses 21179 21188 +9
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Egor Berezovskiy <[email protected]>
d2be32b
to
2ce2214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I'm surprised this doesn't break anything in the CI, I guess we don't have any integration test involving towed rolling stock ... This is an issue for another PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I missed that, I believe it should have been done as part of #9654... but as said by Castavo, no CI step ensures that at the moment 🤷
part of #9637
Add towed rolling stock max speed to python osrd_schemas